Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1590151

[PATCH 3/3] watchdog: retu: restore MFD dependency

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject [PATCH 3/3] watchdog: retu: restore MFD dependency
Date 2017-03-01 11:00 +0100
Message-ID <tg9d8-1fv-17@gated-at.bofh.it> (permalink)
References <tg9d7-1fv-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


The retu watchdog calls into the respective mfd driver, but fails to
link if that is diabled:

drivers/watchdog/built-in.o: In function `retu_wdt_set_timeout':
ziirave_wdt.c:(.text+0x8c88): undefined reference to `retu_write'
ziirave_wdt.c:(.text+0x8c88): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `retu_write'
drivers/watchdog/built-in.o: In function `retu_wdt_start':
ziirave_wdt.c:(.text+0x8cc8): undefined reference to `retu_write'
ziirave_wdt.c:(.text+0x8cc8): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `retu_write'

This restores the dependency as it was before

Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/watchdog/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index a199e8536ce4..52a70ee6014f 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -586,7 +586,7 @@ config UX500_WATCHDOG
 
 config RETU_WATCHDOG
 	tristate "Retu watchdog"
-	depends on MFD_RETU || COMPILE_TEST
+	depends on MFD_RETU
 	select WATCHDOG_CORE
 	help
 	  Retu watchdog driver for Nokia Internet Tablets (770, N800,
-- 
2.9.0

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] remaining watchdog dependency fixes Arnd Bergmann <arnd@arndb.de> - 2017-03-01 11:00 +0100
  [PATCH 3/3] watchdog: retu: restore MFD dependency Arnd Bergmann <arnd@arndb.de> - 2017-03-01 11:00 +0100
    Re: [PATCH 3/3] watchdog: retu: restore MFD dependency Guenter Roeck <linux@roeck-us.net> - 2017-03-01 15:20 +0100
  [PATCH 2/3] watchdog: db8500: add back prmcu dependency Arnd Bergmann <arnd@arndb.de> - 2017-03-01 11:00 +0100
    Re: [PATCH 2/3] watchdog: db8500: add back prmcu dependency Guenter Roeck <linux@roeck-us.net> - 2017-03-01 15:20 +0100
  [PATCH 1/3] watchdog: kempld: fix gcc-4.3 build Arnd Bergmann <arnd@arndb.de> - 2017-03-01 11:00 +0100
    Re: [PATCH 1/3] watchdog: kempld: fix gcc-4.3 build Guenter Roeck <linux@roeck-us.net> - 2017-03-01 15:20 +0100

csiph-web