Re: [Xen-devel] [PATCH 1/5] x86/xen: start untangling PV and PVHVM guest support code

From	Vitaly Kuznetsov <vkuznets@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [Xen-devel] [PATCH 1/5] x86/xen: start untangling PV and PVHVM guest support code
Date	2017-03-01 11:00 +0100
Message-ID	<tg9d7-1fv-1@gated-at.bofh.it> (permalink)
References	<teqL7-2Ds-9@gated-at.bofh.it> <teqL7-2Ds-7@gated-at.bofh.it> <tg5VU-7jj-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Juergen Gross <jgross@suse.com> writes:

> On 24/02/17 17:14, Vitaly Kuznetsov wrote:
>> Introduce CONFIG_XEN_PV config option and split enlighten.c into
>> 4 files. Temporary add #ifdef CONFIG_XEN_PV to smp.c and mmu.c to
>> not break the build and not make the patch even bigger.
>> 
>> xen_cpu_up_prepare*/xen_cpu_die hooks require separation to support
>> future xen_smp_intr_init() split.
>> 
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>
> Could you please split pure code movement and functional changes into
> different patches? This would make review much easier.
>

It's a bit hard with this series to make patches smaller and not break
the build ... :-(

> So 1 patch to split up enlightenment.c and at least one patch for the
> rest of the changes (Kconfig, splitting of x86_hyper_xen, ...).

This sounds doable, I'll try!

-- 
  Vitaly

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] x86/xen: untangle PV and PVHVM guest support code Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-02-24 17:20 +0100
  [PATCH 4/5] x86/xen: put setup.c, pmu.c and apic.c under CONFIG_XEN_PV Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-02-24 17:20 +0100
    Re: [Xen-devel] [PATCH 4/5] x86/xen: put setup.c, pmu.c and apic.c  under CONFIG_XEN_PV Juergen Gross <jgross@suse.com> - 2017-03-01 08:20 +0100
  Re: [Xen-devel] [PATCH 3/5] x86/xen: put setup.c, mmu.c and p2m.c  under CONFIG_XEN_PV Juergen Gross <jgross@suse.com> - 2017-03-01 07:30 +0100
  Re: [Xen-devel] [PATCH 1/5] x86/xen: start untangling PV and PVHVM  guest support code Juergen Gross <jgross@suse.com> - 2017-03-01 07:30 +0100
    Re: [Xen-devel] [PATCH 1/5] x86/xen: start untangling PV and PVHVM guest support code Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-03-01 11:00 +0100

csiph-web