Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1590200

Re: [RESEND 2] [PATCH] rlimits: Print more information when limits are exceeded

Show all headers | View raw

On Sat, 18 Feb 2017, Arun Raghavan wrote:

> This dumps some information in logs when a process exceeds its CPU or RT
> limits (soft and hard). Makes debugging easier when userspace triggers
> these limits.

Sigh. This changelog sucks. "dumps some information" is pretty useless and
it does not explain WHY you want to do that. Please structure the changelog
in a way which makes it easy to understand.

1) Problem description

2) Solution

> diff --git a/kernel/time/posix-cpu-timers.c b/kernel/time/posix-cpu-timers.c
> index e9e8c10..6dbcf84 100644
> --- a/kernel/time/posix-cpu-timers.c
> +++ b/kernel/time/posix-cpu-timers.c
> @@ -860,6 +860,9 @@ static void check_thread_timers(struct task_struct *tsk,
>  			 * At the hard limit, we just die.
>  			 * No need to calculate anything else now.
>  			 */
> +			printk(KERN_INFO

			pr_info("CPU Watchdog Timeout (hard): %s[%d]\n",

and no artificial line breaks, please.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RESEND 2] [PATCH] rlimits: Print more information when limits are exceeded Arun Raghavan <arun@arunraghavan.net> - 2017-02-18 09:40 +0100
  Re: [RESEND 2] [PATCH] rlimits: Print more information when limits are  exceeded Arun Raghavan <arun@arunraghavan.net> - 2017-02-18 16:50 +0100
  Re: [RESEND 2] [PATCH] rlimits: Print more information when limits  are exceeded Thomas Gleixner <tglx@linutronix.de> - 2017-03-01 11:40 +0100
    [PATCH v2] rlimits: Print more information when CPU/RT limits are exceeded Arun Raghavan <arun@arunraghavan.net> - 2017-03-01 16:10 +0100
      [tip:timers/core] rlimits: Print more information when CPU/RT  limits are exceeded tip-bot for Arun Raghavan <tipbot@zytor.com> - 2017-03-13 21:40 +0100

csiph-web