Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1590085
| From | tip-bot for Josh Poimboeuf <tipbot@zytor.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [tip:core/urgent] objtool: Fix __unreachable section relocation size |
| Date | 2017-03-01 09:20 +0100 |
| Message-ID | <tg7El-dA-9@gated-at.bofh.it> (permalink) |
| References | <tg65A-7nF-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Commit-ID: 90a7e63a31b8f7d630d12ef0d8d37d3ab87f76e5
Gitweb: http://git.kernel.org/tip/90a7e63a31b8f7d630d12ef0d8d37d3ab87f76e5
Author: Josh Poimboeuf <jpoimboe@redhat.com>
AuthorDate: Wed, 1 Mar 2017 00:05:04 -0600
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 1 Mar 2017 07:38:25 +0100
objtool: Fix __unreachable section relocation size
Linus reported the following commit broke module loading on his laptop:
d1091c7fa3d5 ("objtool: Improve detection of BUG() and other dead ends")
It showed errors like the following:
module: overflow in relocation type 10 val ffffffffc02afc81
module: 'nvme' likely not compiled with -mcmodel=kernel
The problem is that the __unreachable section addresses are stored using
the '.long' asm directive, which isn't big enough for .text section
relative kernel addresses. Use '.quad' instead.
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: d1091c7fa3d5 ("objtool: Improve detection of BUG() and other dead ends")
Link: http://lkml.kernel.org/r/20170301060504.oltm3iws6fmubnom@treble
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
include/linux/compiler-gcc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
index 76e28c2..91a77a5 100644
--- a/include/linux/compiler-gcc.h
+++ b/include/linux/compiler-gcc.h
@@ -201,7 +201,7 @@
#define annotate_unreachable() ({ \
asm("%c0:\t\n" \
".pushsection __unreachable, \"a\"\t\n" \
- ".long %c0b\t\n" \
+ ".quad %c0b\t\n" \
".popsection\t\n" : : "i" (__LINE__)); \
})
#else
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[GIT PULL] objtool fixes Ingo Molnar <mingo@kernel.org> - 2017-02-28 09:00 +0100
Re: [GIT PULL] objtool fixes Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-01 03:10 +0100
Re: [GIT PULL] objtool fixes Josh Poimboeuf <jpoimboe@redhat.com> - 2017-03-01 07:40 +0100
[tip:core/urgent] objtool: Fix __unreachable section relocation size tip-bot for Josh Poimboeuf <tipbot@zytor.com> - 2017-03-01 09:20 +0100
Re: [tip:core/urgent] objtool: Fix __unreachable section relocation size hpa@zytor.com - 2017-03-01 09:50 +0100
[PATCH] objtool, compiler.h: Fix __unreachable section relocation size Ingo Molnar <mingo@kernel.org> - 2017-03-01 14:00 +0100
Re: [PATCH] objtool, compiler.h: Fix __unreachable section relocation size Josh Poimboeuf <jpoimboe@redhat.com> - 2017-03-01 14:00 +0100
Re: [tip:core/urgent] objtool: Fix __unreachable section relocation size Josh Poimboeuf <jpoimboe@redhat.com> - 2017-03-01 14:00 +0100
Re: [tip:core/urgent] objtool: Fix __unreachable section relocation size Ingo Molnar <mingo@kernel.org> - 2017-03-01 11:40 +0100
Re: [tip:core/urgent] objtool: Fix __unreachable section relocation size Josh Poimboeuf <jpoimboe@redhat.com> - 2017-03-01 14:00 +0100
[tip:core/urgent] objtool, compiler.h: Fix __unreachable section relocation size tip-bot for Josh Poimboeuf <tipbot@zytor.com> - 2017-03-01 14:30 +0100
[tip:core/urgent] objtool, compiler.h: Fix __unreachable section relocation size tip-bot for Josh Poimboeuf <tipbot@zytor.com> - 2017-03-01 15:40 +0100
csiph-web