Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1590027

Re: [GIT PULL] locking fixes

Show all headers | View raw

On Mon, Feb 27, 2017 at 11:57 PM, Ingo Molnar <mingo@kernel.org> wrote:
>
> Note that the uninlining allowed us to enable the underflow/overflow warnings
> unconditionally and remove the debug Kconfig switch: this might trigger new
> warnings in buggy code and turn crashes/use-after-free bugs into less harmful
> memory leaks.

I'm ok with this, but that WARN() really needs to be a WARN_ON_ONCE().

Because once an underflow (or overflow) is happening, it tends to
_keep_ happening. And you may just have essentially DoS'ed the machine
that is now spending all its time writing those logs to disk.

Yes, yes, quiet independently of this we should limit WARN printouts
(and do the reverse: turn a "once" to mean "once in a blue moon"
rather than actually just once), but particularly for this kind of
"never happens" thing, it really is better to just warn once.

                   Linus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL] locking fixes Ingo Molnar <mingo@kernel.org> - 2017-02-28 09:10 +0100
  Re: [GIT PULL] locking fixes Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-01 07:30 +0100
    [PATCH] locking/refcounts: Change WARN() to WARN_ONCE() Ingo Molnar <mingo@kernel.org> - 2017-03-01 09:50 +0100
    [tip:locking/urgent] locking/refcounts: Change WARN() to  WARN_ONCE() tip-bot for Ingo Molnar <tipbot@zytor.com> - 2017-03-01 09:50 +0100

csiph-web