Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1589984

Re: [v2] Input: pwm-beeper: support customized freq for SND_BELL

From Heiko Schocher <hs@denx.de>
Newsgroups linux.kernel
Subject Re: [v2] Input: pwm-beeper: support customized freq for SND_BELL
Date 2017-03-01 06:30 +0100
Message-ID <tg4ZQ-6FG-5@gated-at.bofh.it> (permalink)
References (1 earlier) <tfzsZ-1N7-11@gated-at.bofh.it> <tfIwi-8lA-3@gated-at.bofh.it> <tfIFX-8oQ-3@gated-at.bofh.it> <tfJsm-zM-7@gated-at.bofh.it> <tfJsm-zM-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hello Dimitry,

Am 28.02.2017 um 07:20 schrieb Dmitry Torokhov:
> On February 27, 2017 10:13:43 PM PST, Heiko Schocher <hs@denx.de> wrote:
>> Hello David,
>>
>> Am 28.02.2017 um 06:30 schrieb David Lechner:
>>> On 02/27/2017 11:19 PM, Heiko Schocher wrote:
>>>> Hello David,
>>>>
>>>> Am 27.02.2017 um 19:11 schrieb David Lechner:
>>>>> On 02/20/2017 02:37 AM, Heiko Schocher wrote:
>>>>>> From: Guan Ben <ben.guan@cn.bosch.com>
>>>>>>
>>>>>> extend the pwm-beeper driver to support customized frequency
>>>>>> for SND_BELL from device tree.
>>>>>>
>>>>>> Signed-off-by: Guan Ben <ben.guan@cn.bosch.com>
>>>>>> Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
>>>>>> [hs@denx.de: adapted to 4.10-rc7]
>>>>>> Signed-off-by: Heiko Schocher <hs@denx.de>
>>>>>> ---
>>>>>>
>>>>>> Changes in v2:
>>>>>> - add comment from Rob Herring:
>>>>>>    rename property name "bell-frequency" to "beeper-hz"
>>>>>
>>>>> Is there a separate patch for the devicetree bindings
>> documentation?
>>>>
>>>> No, it is in this patch ... In the meantime I got an
>>>> Acked-by from Rob Herring ...
>>>>
>>>
>>> What I should have said is that, in general, I think it is preferred
>> to have the device tree
>>> bindings as a separate patch from the code changes.
>>
>> I can split this into 2 patches ...
>
> Don't - since Rob already asked DT change you don't need to post to device tree list again and I'll merge them back together since they do not make sense separately.

Ok, I post a v3 with the changes suggested from David and Rob soon,
without splitting.

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] Input: pwm-beeper: support customized freq for SND_BELL Heiko Schocher <hs@denx.de> - 2017-02-20 09:40 +0100
  Re: [v2] Input: pwm-beeper: support customized freq for SND_BELL David Lechner <david@lechnology.com> - 2017-02-27 20:50 +0100
    Re: [v2] Input: pwm-beeper: support customized freq for SND_BELL Heiko Schocher <hs@denx.de> - 2017-02-28 06:30 +0100
      Re: [v2] Input: pwm-beeper: support customized freq for SND_BELL David Lechner <david@lechnology.com> - 2017-02-28 06:40 +0100
        Re: [v2] Input: pwm-beeper: support customized freq for SND_BELL Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-28 07:30 +0100
          Re: [v2] Input: pwm-beeper: support customized freq for SND_BELL Heiko Schocher <hs@denx.de> - 2017-03-01 06:30 +0100
        Re: [v2] Input: pwm-beeper: support customized freq for SND_BELL Heiko Schocher <hs@denx.de> - 2017-02-28 08:20 +0100
  Re: [PATCH v2] Input: pwm-beeper: support customized freq for  SND_BELL Rob Herring <robh@kernel.org> - 2017-02-28 02:10 +0100
    Re: [PATCH v2] Input: pwm-beeper: support customized freq for  SND_BELL Heiko Schocher <hs@denx.de> - 2017-02-28 06:30 +0100

csiph-web