Re: [PATCH 2/2] mfd: add TI LMU driver

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] mfd: add TI LMU driver
Date	2017-03-01 03:50 +0100
Message-ID	<tg2v0-4Iq-5@gated-at.bofh.it> (permalink)
References	<tfJLI-GX-7@gated-at.bofh.it> <tfJLI-GX-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Milo Kim <milo.kim@ti.com> [170227 22:47]:
> TI LMU (Lighting Management Unit) driver supports lighting devices below.
> 
>   LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697.
> 
> LMU devices have common features.
>   - I2C interface for accessing device registers
>   - Hardware enable pin control
>   - Backlight brightness control
>   - Notifier for hardware fault monitoring
>   - Regulators for LCD display bias
> 
> It contains fault monitor, backlight, LED and regulator driver.
> 
> LMU fault monitor
> -----------------
>   LM3633 and LM3697 provide hardware monitoring feature.
>   It enables open or short circuit detection.
>   After monitoring is done, each device should be re-initialized.
>   Notifier is used for this case.
>   Separate patch for 'ti-lmu-fault-monitor' will be sent later.
> 
> Backlight
> ---------
>   It's handled by TI LMU backlight consolidated driver and
>   chip dependent data. Separate patchset will be sent later.
> 
> LED indicator
> -------------
>   LM3633 has 6 indicator LEDs. Programmable dimming pattern is also
>   supported. Separate patch for 'leds-lm3633' will be sent later.
> 
> Regulator
> ---------
>   LM3631 has 5 regulators for the display bias.
>   LM3632 supports 3 regulators. One consolidated driver enables it.
>   The lm363x regulator driver is already upstreamed.
> 
> Acked-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Milo Kim <milo.kim@ti.com>

This works for me on droid 4 with LM3632 using your earlier
"[v2,7/9] backlight: add TI LMU backlight driver" patch at
https://patchwork.kernel.org/patch/7704601/

I had to update the dts file according to the binding and then
enable backlight after booting with:

# echo 180 > /sys/class/backlight/lcd/brightness

So please feel free to add:

Tested-by: Tony Lindgren <tony@atomide.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] mfd: add TI LMU driver Milo Kim <milo.kim@ti.com> - 2017-02-28 07:50 +0100
  Re: [PATCH 2/2] mfd: add TI LMU driver Tony Lindgren <tony@atomide.com> - 2017-03-01 03:50 +0100

csiph-web