Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589938

Re: net: GPF in rt6_nexthop_info

From David Ahern <dsa@cumulusnetworks.com>
Newsgroups linux.kernel
Subject Re: net: GPF in rt6_nexthop_info
Date 2017-03-01 03:00 +0100
Message-ID <tg1IB-48Z-1@gated-at.bofh.it> (permalink)
References <tfOil-3OY-1@gated-at.bofh.it> <tfPR7-4Up-9@gated-at.bofh.it> <tfZdL-2BN-17@gated-at.bofh.it> <tfZdL-2BN-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 2/28/17 3:14 PM, Eric Dumazet wrote:
> On Tue, Feb 28, 2017 at 3:09 PM, David Ahern <dsa@cumulusnetworks.com> wrote:
>> On 2/28/17 5:10 AM, Eric Dumazet wrote:
>>> David, rt->rt6i_idev can be NULL.
>>
>> Do you know of an example where rt6i_idev can be NULL - besides the
>> null_entry rt which is null only because of init order?
> 
> 
> I might have been mistaken, but many points in net/ipv6/route.c test
> rt->rt6i_idev being NULL or not before dereferencing it.
> 
> Maybe other rts (other than null_entry) share this property.
> 

Seen those and always been confused that an L3 route object does not
require the L3 addr struct for the device.

Code wise the struct is allocated for all net devices at registration as
long as mtu >= 1280. If it is not allocated, routes referencing the
device fail with ENODEV (idev check in ip6_route_info_create). Putting
that together I can't see how a standard ipv6 rt other than the
null_entry can reference a null rt6i_idev.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

net: GPF in rt6_nexthop_info Dmitry Vyukov <dvyukov@google.com> - 2017-02-28 12:40 +0100
  Re: net: GPF in rt6_nexthop_info Eric Dumazet <eric.dumazet@gmail.com> - 2017-02-28 14:20 +0100
    Re: net: GPF in rt6_nexthop_info Dmitry Vyukov <dvyukov@google.com> - 2017-02-28 14:40 +0100
      Re: net: GPF in rt6_nexthop_info Eric Dumazet <eric.dumazet@gmail.com> - 2017-02-28 15:00 +0100
    Re: net: GPF in rt6_nexthop_info Cong Wang <xiyou.wangcong@gmail.com> - 2017-02-28 19:30 +0100
    Re: net: GPF in rt6_nexthop_info Eric Dumazet <edumazet@google.com> - 2017-03-01 00:20 +0100
      Re: net: GPF in rt6_nexthop_info David Ahern <dsa@cumulusnetworks.com> - 2017-03-01 03:00 +0100
    Re: net: GPF in rt6_nexthop_info David Ahern <dsa@cumulusnetworks.com> - 2017-03-01 00:50 +0100

csiph-web