Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1589889

Re: [PATCH 4/5] ARM: dts: qcom-apq8064: Collapse usb support into one node

Path csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From John Stultz <john.stultz@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH 4/5] ARM: dts: qcom-apq8064: Collapse usb support into one node
Date Wed, 01 Mar 2017 01:10:02 +0100
Message-ID <tg00a-3dN-17@gated-at.bofh.it> (permalink)
References <t42TM-5O4-3@gated-at.bofh.it> <t42TM-5O4-1@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1yHYvdMZUXZpb4Sw+v1ced4gPl3oqNo3nPqrtICJzps=; b=kEMaUHugpdxPI/hFPJ1KRvPdTyk9guFYx6Dwh1fcdMRd0kOWBDmvOAgjInhbZFUo6l YanBl3AnSjp8bxxaiDPEF6s1YAMJ/x3gmmGt/DdTo2lyw562+SJt9jhmwLAwurdZieiR jkbGtXdLhcdpXdvf0P1lWjOGw6P1K4BAujG5g=
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1yHYvdMZUXZpb4Sw+v1ced4gPl3oqNo3nPqrtICJzps=; b=MKcKnNjAcGlUN1ARq5fd284tkYc5fbTva/sptdD6WAxpJbzlmj1Z3vllnXC3SC2ACL nZ+YAlbk7FwD3eX112Ao8VUPqSceH68cyjbAs/kDsW7a7hmS1ga/kNaK0hHnrEPzphtd ZDz9dLzqM7r2sfNnQM9hp2JzG/mxAclJALate0xQfAbetvWDuxc0ug/IC+/oJ4XIa2dH oHZP/xje1kmOguzSz9qYqC6mj/ewEm97LV0uP2b8Fjxc2JBDPNPvfrrAAK/mQEbXX/yj v9QuOVF3rxX7RvfR1jyjoRUqRm4e6etyNh590+MliywGKUUQxiwMtN2NMmBCG1KpMNu6 JQUg==
X-Gm-Message-State AMke39nG4YG1K1udas/qiNn8T80heWzWLtv7+CKxCpg2MWXLZUf+fbWkZ3DOn3o3Oq/bU/L9NEw9RaPtXcixDYuL
X-Received by 10.223.145.227 with SMTP id 90mr4606575wri.156.1488325831773; Tue, 28 Feb 2017 15:50:31 -0800 (PST)
MIME-Version 1.0
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 28
Organization linux.* mail to news gateway
X-Original-Cc Andy Gross <andy.gross@linaro.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, lkml <linux-kernel@vger.kernel.org>, "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Nicolas Dechesne <nicolas.dechesne@linaro.org>
X-Original-Date Tue, 28 Feb 2017 15:50:31 -0800
X-Original-Message-ID <CALAqxLVeqn0GJGQsYtkiX454q5Q1OsnJTCBAh4kG-0jWjByTdg@mail.gmail.com>
X-Original-References <20170127004728.22490-1-stephen.boyd@linaro.org> <20170127004728.22490-5-stephen.boyd@linaro.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1589889

Show key headers only | View raw


On Thu, Jan 26, 2017 at 4:47 PM, Stephen Boyd <stephen.boyd@linaro.org> wrote:
> We currently have three device nodes for the same USB hardware
> block, as evident by the reuse of the same reg address multiple
> times. Now that the chipidea driver fully supports OTG with the
> MSM wrapper we can collapse the three nodes into one USB device
> node, reflecting the true nature of the hardware.
>
> Since we're here, we also mark the irq trigger flags correctly,
> as IRQ_TYPE_LEVEL_HIGH instead of IRQ_TYPE_NONE.
>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Cc: Nicolas Dechesne <nicolas.dechesne@linaro.org>
> Cc: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>


Applies with noise now, but I was able to get USB working with this
and some changes to my config.

Hotplug still doesn't work, but that was the same situation before as
well, so I need to dig on that.

So..
Tested-by: John Stultz <john.stultz@linaro.org>

thanks
-john

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH 4/5] ARM: dts: qcom-apq8064: Collapse usb support into one node John Stultz <john.stultz@linaro.org> - 2017-03-01 01:10 +0100

csiph-web