Re: [PATCH v2 1/2] Documentation: devicetree: Add i2c binding for mediatek MT2701 Soc Platform

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] Documentation: devicetree: Add i2c binding for mediatek MT2701 Soc Platform
Date	Mon, 27 Feb 2017 19:30:03 +0100
Message-ID	<tfydB-Zv-23@gated-at.bofh.it> (permalink)
References	<taXFD-1Hw-11@gated-at.bofh.it> <taXFD-1Hw-9@gated-at.bofh.it>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=j8Xrhhvc47njK9xAbTPwFKcMBQtyHIQlz69p0FRA/NQ=; b=QkW318VoibBaN27cbGzX9nrjYuYSc6iEu0xbzNqKKEd5OcjFvOelvqpfIrijktAJjF kEWipEZhqG4d0dgnVctN4WTWDHmeOvkm73V5yE68DFTt0FmdAWKa+0q1ryLQPc00BpNY 6T5dZTJWY86Dg8paQ/EFbXOHpKauo3w/a8LpDy5/UQulySAOmg3RddSPbQAJ8TSdHUZF vJ4p5MKojvb0CMiaZLJleifR6qihcmlFhwyp8dFMCiN0n/OmjxOhy+EcS8e0pBvNZabZ 4PE9p3m92oblvhtHDhCitozrEg0+JLS0bia7E7GLqbZcbwOf7xS4aAaPeuSJxfwXP6OS tuKg==
X-Gm-Message-State	AMke39nm04dAhzsn1qQUYF3BsSclFfjDkJ5V5pdzIWAjWTLvs6d04r3bv+Jvii1jdxgV3w==
X-Received	by 10.157.17.133 with SMTP id v5mr7957274otf.137.1488215668492; Mon, 27 Feb 2017 09:14:28 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.6.2-neo (2016-08-21)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	50
Organization	linux.* mail to news gateway
X-Original-Cc	Wolfram Sang <wsa@the-dreams.de>, Matthias Brugger <matthias.bgg@gmail.com>, srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
X-Original-Date	Mon, 27 Feb 2017 11:14:27 -0600
X-Original-Message-ID	<20170227171427.4szwecmvn3qzytjz@rob-hp-laptop>
X-Original-References	<1487125976-25243-1-git-send-email-jun.gao@mediatek.com> <1487125976-25243-2-git-send-email-jun.gao@mediatek.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1588856

Show key headers only | View raw

On Wed, Feb 15, 2017 at 10:32:55AM +0800, Jun Gao wrote:
> From: Jun Gao <jun.gao@mediatek.com>
> 
> Add i2c DT binding to i2c-mt6577.txt for MT2701 and there is no need to modify i2c driver.

Wrap your lines.

> 
> Change-Id: I892f866d755aa3865bffd1a80884cd41b6ecc1f1

Remove Gerrit Ids.

> Signed-off-by: Jun Gao <jun.gao@mediatek.com>
> ---
>  .../devicetree/bindings/i2c/i2c-mt6577.txt         |   11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
> index 0ce6fa3..ef22ecf 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
> @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
>  
>  Required properties:
>    - compatible: value should be either of the following.
> -      (a) "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c.
> -      (b) "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c.
> -      (c) "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c.
> -      (d) "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c.
> -      (e) "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c.
> +	"mediatek,mt2701-i2c", for i2c compatible with mt2701 i2c.
> +	"mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c.
> +	"mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c.
> +	"mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c.
> +	"mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c.
> +	"mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c.

All the parts after the compatible strings are a bit redundant. Just 
drop them.

>    - reg: physical base address of the controller and dma base, length of memory
>      mapped region.
>    - interrupts: interrupt number to the cpu.
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] Documentation: devicetree: Add i2c binding for mediatek MT2701 Soc Platform Jun Gao <jun.gao@mediatek.com> - 2017-02-15 03:40 +0100
  Re: [PATCH v2 1/2] Documentation: devicetree: Add i2c binding for  mediatek MT2701 Soc Platform Rob Herring <robh@kernel.org> - 2017-02-27 19:00 +0100
  Re: [PATCH v2 1/2] Documentation: devicetree: Add i2c binding for  mediatek MT2701 Soc Platform Rob Herring <robh@kernel.org> - 2017-02-27 19:30 +0100

csiph-web