Re: [PATCH v2 1/2] of: add devm_ functions for populate and depopulate

From	Daniel Vetter <daniel@ffwll.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] of: add devm_ functions for populate and depopulate
Date	2017-02-27 17:50 +0100
Message-ID	<tfwEO-8dT-31@gated-at.bofh.it> (permalink)
References	<teqL7-2Ds-3@gated-at.bofh.it> <teqL7-2Ds-1@gated-at.bofh.it> <ter4t-2Kh-3@gated-at.bofh.it> <tfdst-3gq-13@gated-at.bofh.it> <tftQC-6g8-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 27, 2017 at 07:30:24AM -0600, Rob Herring wrote:
> On Sun, Feb 26, 2017 at 2:11 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Fri, Feb 24, 2017 at 10:31:25AM -0600, Rob Herring wrote:
> >> On Fri, Feb 24, 2017 at 10:14 AM, Benjamin Gaignard
> >> <benjamin.gaignard@linaro.org> wrote:
> >> > Lots of calls to of_platform_populate() are not unbalanced by a call
> >> > to of_platform_depopulate(). This create issues while drivers are
> >> > bind/unbind.
> >> >
> >> > In way to solve those issues is to add devm_of_platform_populate()
> >> > which will call of_platform_depopulate() when the device is unbound
> >> > from the bus.
> >> >
> >> > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> >> > ---
> >> > version 2:
> >> > - simplify function prototype to only keep device as parameter
> >> >
> >> >  drivers/of/platform.c       | 71 +++++++++++++++++++++++++++++++++++++++++++++
> >> >  include/linux/of_platform.h | 11 +++++++
> >> >  2 files changed, 82 insertions(+)
> >>
> >> For this and patch 2:
> >>
> >> Acked-by: Rob Herring <robh@kernel.org>
> >
> > Is this an ack for merging both through drm-misc, or should we do a
> > topic-branch dance here?
> 
> You can apply it directly.

Ok, this seems like a pretty cool idea, so applied both to drm-misc for
4.12.

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] of: add devm_ functions for populate and depopulate Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-02-24 17:20 +0100
  Re: [PATCH v2 1/2] of: add devm_ functions for populate and depopulate Rob Herring <robh+dt@kernel.org> - 2017-02-24 17:40 +0100
    Re: [PATCH v2 1/2] of: add devm_ functions for populate and  depopulate Daniel Vetter <daniel@ffwll.ch> - 2017-02-26 21:20 +0100
      Re: [PATCH v2 1/2] of: add devm_ functions for populate and depopulate Rob Herring <robh+dt@kernel.org> - 2017-02-27 14:50 +0100
        Re: [PATCH v2 1/2] of: add devm_ functions for populate and  depopulate Daniel Vetter <daniel@ffwll.ch> - 2017-02-27 17:50 +0100

csiph-web