Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588759

[PATCH] lockdep: Fix compilation error for !CONFIG_MODULES and !CONFIG_SMP

Show all headers | View raw

From: Dan Murphy <dmurphy@ti.com>

When CONFIG_MODULES is not set then it fails to compile in lockdep:

|kernel/locking/lockdep.c: In function 'look_up_lock_class':
|kernel/locking/lockdep.c:684:12: error: implicit declaration of function
| '__is_module_percpu_address' [-Werror=implicit-function-declaration]

If CONFIG_MODULES is set but CONFIG_SMP is not, then it compiles but
fails link at the end:

|kernel/locking/lockdep.c:684: undefined reference to `__is_module_percpu_address'
|kernel/built-in.o:(.debug_addr+0x1e674): undefined reference to `__is_module_percpu_address'

This patch adds the function for both cases.

Signed-off-by: Dan Murphy <dmurphy@ti.com>
[bigeasy: merge the two patches from Dan into one, adapt changelog]
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 include/linux/module.h | 5 +++++
 kernel/module.c        | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/include/linux/module.h b/include/linux/module.h
index 2d209ecbfde1..ec5c4e63201a 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -664,6 +664,11 @@ static inline bool is_module_percpu_address(unsigned long addr)
 	return false;
 }
 
+static inline bool __is_module_percpu_address(unsigned long addr, unsigned long *can_addr)
+{
+	return false;
+}
+
 static inline bool is_module_text_address(unsigned long addr)
 {
 	return false;
diff --git a/kernel/module.c b/kernel/module.c
index 0bbfcf69760c..b54cb4fbbcad 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -737,6 +737,11 @@ bool is_module_percpu_address(unsigned long addr)
 	return false;
 }
 
+bool __is_module_percpu_address(unsigned long addr, unsigned long *can_addr)
+{
+	return false;
+}
+
 #endif /* CONFIG_SMP */
 
 #define MODINFO_ATTR(field)	\
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] lockdep: Handle statically initialized PER_CPU locks  proper Thomas Gleixner <tglx@linutronix.de> - 2017-02-17 19:50 +0100
  [PATCH] lockdep: Fix compilation error for !CONFIG_MODULES and  !CONFIG_SMP Sebastian Sewior <bigeasy@linutronix.de> - 2017-02-27 16:40 +0100
    [PATCH v2] lockdep: Handle statically initialized PER_CPU locks  proper Sebastian Sewior <bigeasy@linutronix.de> - 2017-02-27 16:40 +0100

csiph-web