Re: [PATCH] asm-generic: Force cast get_user() setting x to 0

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] asm-generic: Force cast get_user() setting x to 0
Date	2017-02-27 17:00 +0100
Message-ID	<tfvSq-7FO-5@gated-at.bofh.it> (permalink)
References	<tbU30-6Np-13@gated-at.bofh.it> <tezlo-mo-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Feb 25, 2017 at 2:24 AM, Stephen Boyd <stephen.boyd@linaro.org> wrote:
> Quoting Stephen Boyd (2017-02-17 08:52:29)
>> If we call get_user() with an __le* or __be* type sparse will
>> complain when we assign the result to 0 on the faulting path.
>> Let's force cast here so that sparse doesn't complain. This
>> mirrors what we do in __get_user() as well.
>>
>> Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
>> ---
>>
>> I made a similar fix to arm64 headers, and it looks like asm-generic
>> would need the same fix.
>
> I suppose we can ignore this. I was using sparse v0.5.0 but it seems
> that later versions of sparse don't complain here anymore as Luc has
> pointed out.

Ok, thanks for the follow-up.

   Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] asm-generic: Force cast get_user() setting x to 0 Stephen Boyd <stephen.boyd@linaro.org> - 2017-02-17 18:00 +0100
  Re: [PATCH] asm-generic: Force cast get_user() setting x to 0 Stephen Boyd <stephen.boyd@linaro.org> - 2017-02-25 02:30 +0100
    Re: [PATCH] asm-generic: Force cast get_user() setting x to 0 Arnd Bergmann <arnd@arndb.de> - 2017-02-27 17:00 +0100

csiph-web