Re: [PATCH-tip 2/3] locking/rwsem: move down rwsem_down_read_failed()

From	Waiman Long <longman@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH-tip 2/3] locking/rwsem: move down rwsem_down_read_failed()
Date	2017-02-27 15:50 +0100
Message-ID	<tfuMH-6Wf-35@gated-at.bofh.it> (permalink)
References	<tdJwt-5DY-5@gated-at.bofh.it> <tdJwu-5DY-11@gated-at.bofh.it> <tfdCa-3lA-7@gated-at.bofh.it>
Organization	Red Hat

Show all headers | View raw

On 02/26/2017 01:33 PM, Davidlohr Bueso wrote:
> On Wed, 22 Feb 2017, Waiman Long wrote:
>
>> Move the rwsem_down_read_failed() function down to below the
>> optimistic spinning section as it is going to use function in that
>> section in a later patch.
>
> So the title is a bit ambiguous, and I would argue that this
> should be folded into patch 3, and just mention it in the
> changelog.
>
> Thanks,
> Davidlohr

I can reword the title to clarify it a bit more.

The reason why it is a separate patch is because it will make it much
harder to review the third patch otherwise. What you get from the diff
will be a total replacement of one function block by another function
block. I would like to make the review focus on what is actually being
changed.

Cheers,
Longman

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH-tip 2/3] locking/rwsem: move down rwsem_down_read_failed() Waiman Long <longman@redhat.com> - 2017-02-22 19:10 +0100
  Re: [PATCH-tip 2/3] locking/rwsem: move down rwsem_down_read_failed() Davidlohr Bueso <dave@stgolabs.net> - 2017-02-26 21:30 +0100
    Re: [PATCH-tip 2/3] locking/rwsem: move down rwsem_down_read_failed() Waiman Long <longman@redhat.com> - 2017-02-27 15:50 +0100

csiph-web