Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588631

Re: [PATCH v3 20/20] checkpatch: warn for use of old PCI pool API

Show all headers | View raw

On Mon, 2017-02-27 at 12:22 +0100, Peter Senna Tschudin wrote:
> On Sun, Feb 26, 2017 at 08:24:25PM +0100, Romain Perier wrote:
> > pci_pool_*() functions should be replaced by the corresponding functions
> > in the DMA pool API. This adds support to check for use of these pci
> > functions and display a warning when it is the case.
> > 
> 
> I guess Joe Perches did sent some comments for this one, did you address
> them?


> Reviewed-by: Peter Senna Tschudin <peter.senna@collabora.com>
> > Signed-off-by: Romain Perier <romain.perier@collabora.com>
> > ---
> >  scripts/checkpatch.pl | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> > 
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index baa3c7b..f2c775c 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -6064,7 +6064,14 @@ sub process {
> >  			WARN("USE_DEVICE_INITCALL",
> >  			     "please use device_initcall() or more appropriate function instead of __initcall() (see include/linux/init.h)\n" . $herecurr);
> >  		}
> > -
> > +# check for old PCI api pci_pool_*(), use dma_pool_*() instead
> > +		if ($line =~ /\bpci_pool(?:_(?:create|destroy|alloc|zalloc|free)|)\b/) {
> > +			if (WARN("USE_DMA_POOL",
> > +				 "please use the dma pool api or more appropriate function instead of the old pci pool api\n" . $herecurr) &&
> > +			    $fix) {
> > +				while ($fixed[$fixlinenr] =~ s/\bpci_pool(_(?:create|destroy|alloc|zalloc|free)|)\b/dma_pool$1/) {}
> > +			}
> > +		}
> >  # check for various structs that are normally const (ops, kgdb, device_tree)
> >  		if ($line !~ /\bconst\b/ &&
> >  		    $line =~ /\bstruct\s+($const_structs)\b/) {
> > 

This is nearly identical to the suggestion that I
sent but this is slightly misformatted as it does
not have a leading nor a trailing blank line to
separate the test blocks.

Also, I think none of the patches have reached lkml.

Romain, are you using git-send-email to send these
patches?  Perhaps the patches you send also contain
html which are rejected by the mailing list.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 20/20] checkpatch: warn for use of old PCI pool API Peter Senna Tschudin <peter.senna@collabora.com> - 2017-02-27 12:30 +0100
  Re: [PATCH v3 20/20] checkpatch: warn for use of old PCI pool API Joe Perches <joe@perches.com> - 2017-02-27 13:00 +0100
  Re: [PATCH v3 20/20] checkpatch: warn for use of old PCI pool API Romain Perier <romain.perier@collabora.com> - 2017-02-27 13:30 +0100
    Re: [PATCH v3 20/20] checkpatch: warn for use of old PCI pool API Joe Perches <joe@perches.com> - 2017-02-27 13:50 +0100
      Re: [PATCH v3 20/20] checkpatch: warn for use of old PCI pool API Romain Perier <romain.perier@collabora.com> - 2017-02-27 14:00 +0100
        Re: [PATCH v3 20/20] checkpatch: warn for use of old PCI pool API Joe Perches <joe@perches.com> - 2017-02-27 17:00 +0100

csiph-web