Re: [PATCH 5/7] watchdog: s3c2410: Constify local structures

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/7] watchdog: s3c2410: Constify local structures
Date	2017-02-27 06:20 +0100
Message-ID	<tflT3-F5-3@gated-at.bofh.it> (permalink)
References	<tevhL-5TR-3@gated-at.bofh.it> <tevrr-5ZH-3@gated-at.bofh.it> <tewdQ-6CD-13@gated-at.bofh.it> <teFh7-4vY-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02/24/2017 11:42 PM, Krzysztof Kozlowski wrote:
> On Fri, Feb 24, 2017 at 02:05:56PM -0800, Guenter Roeck wrote:
>> On 02/24/2017 01:07 PM, Krzysztof Kozlowski wrote:
>>> Structures watchdog_device, watchdog_ops and s3c2410_wdt_variant are not
>>> modified so they can be made const to increase code safeness.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>
>> Conflicts with "watchdog: constify watchdog_ops structures" in my tree.
>> I rebased my tree to v4.10 (which I should not really have done ;-), but
>> it still doesn't apply due to "fatal: sha1 information is lacking or useless"
>> and "error: could not build fake ancestor". The subsequent patches also don't
>> apply. You may have to wait until after -rc1, rebase your patches, and
>> resubmit.
>
> Sure, I'll resend after merge window. These aren't important fixes so
> there is no problem in waiting for merge window to end.
>

Watchdog patches are in, so please feel free to resubmit at your convenience.

Thanks,
Guenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 5/7] watchdog: s3c2410: Constify local structures Krzysztof Kozlowski <krzk@kernel.org> - 2017-02-24 22:20 +0100
  Re: [PATCH 5/7] watchdog: s3c2410: Constify local structures Guenter Roeck <linux@roeck-us.net> - 2017-02-24 23:10 +0100
    Re: [PATCH 5/7] watchdog: s3c2410: Constify local structures Krzysztof Kozlowski <krzk@kernel.org> - 2017-02-25 08:50 +0100
      Re: [PATCH 5/7] watchdog: s3c2410: Constify local structures Guenter Roeck <linux@roeck-us.net> - 2017-02-27 06:20 +0100

csiph-web