Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588413

Re: [PATCH 3/3] drm/tinydrm: helpers: Properly fix backlight dependency

Show all headers | View raw

Den 23.02.2017 14.29, skrev Noralf Trønnes:
> BACKLIGHT_CLASS_DEVICE was selected in the last version of the
> tinydrm patchset to fix the backlight dependency, but the
> ifdef CONFIG_BACKLIGHT_CLASS_DEVICE was forgotten. Fix that.
>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> ---

Please apply this, it causes a build error if backlight is built as
a module. In my haste to fix the problems reported after tinydrm was
pulled, I mistook it for a warning so it was mislabeled.
Sorry about the noise caused by tinydrm.

Noralf.


>   include/drm/tinydrm/tinydrm-helpers.h | 19 -------------------
>   1 file changed, 19 deletions(-)
>
> diff --git a/include/drm/tinydrm/tinydrm-helpers.h b/include/drm/tinydrm/tinydrm-helpers.h
> index 78175fe..9b9b6cf 100644
> --- a/include/drm/tinydrm/tinydrm-helpers.h
> +++ b/include/drm/tinydrm/tinydrm-helpers.h
> @@ -44,28 +44,9 @@ void tinydrm_xrgb8888_to_rgb565(u16 *dst, void *vaddr,
>   				struct drm_framebuffer *fb,
>   				struct drm_clip_rect *clip, bool swap);
>   
> -#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE
>   struct backlight_device *tinydrm_of_find_backlight(struct device *dev);
>   int tinydrm_enable_backlight(struct backlight_device *backlight);
>   int tinydrm_disable_backlight(struct backlight_device *backlight);
> -#else
> -static inline struct backlight_device *
> -tinydrm_of_find_backlight(struct device *dev)
> -{
> -	return NULL;
> -}
> -
> -static inline int tinydrm_enable_backlight(struct backlight_device *backlight)
> -{
> -	return 0;
> -}
> -
> -static inline int
> -tinydrm_disable_backlight(struct backlight_device *backlight)
> -{
> -	return 0;
> -}
> -#endif
>   
>   size_t tinydrm_spi_max_transfer_size(struct spi_device *spi, size_t max_len);
>   bool tinydrm_spi_bpw_supported(struct spi_device *spi, u8 bpw);

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] drm/tinydrm: Fix compiler warnings Noralf Trønnes <noralf@tronnes.org> - 2017-02-23 14:40 +0100
  [PATCH 1/3] drm/tinydrm: mipi-dbi: Silence: ‘cmd’ may be used uninitialized Noralf Trønnes <noralf@tronnes.org> - 2017-02-23 14:40 +0100
  [PATCH 2/3] drm/tinydrm: mipi-dbi: Fix field width specifier warning Noralf Trønnes <noralf@tronnes.org> - 2017-02-23 14:40 +0100
  [PATCH 3/3] drm/tinydrm: helpers: Properly fix backlight dependency Noralf Trønnes <noralf@tronnes.org> - 2017-02-23 14:40 +0100
    Re: [PATCH 3/3] drm/tinydrm: helpers: Properly fix backlight  dependency Noralf Trønnes <noralf@tronnes.org> - 2017-02-26 23:50 +0100
      Re: [PATCH 3/3] drm/tinydrm: helpers: Properly fix backlight  dependency Daniel Vetter <daniel@ffwll.ch> - 2017-02-27 01:10 +0100
  Re: [PATCH 0/3] drm/tinydrm: Fix compiler warnings Noralf Trønnes <noralf@tronnes.org> - 2017-02-24 02:40 +0100

csiph-web