Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589823

Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce buffer support

From Richard Weinberger <richard@nod.at>
Newsgroups linux.kernel
Subject Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce buffer support
Date 2017-02-28 22:50 +0100
Message-ID <tfXOG-1BX-11@gated-at.bofh.it> (permalink)
References <tfsrv-5qX-11@gated-at.bofh.it> <tfsrw-5qX-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Vignesh,

Am 27.02.2017 um 13:08 schrieb Vignesh R:
> Many SPI controller drivers use DMA to read/write from m25p80 compatible
> flashes. Therefore enable bounce buffers support provided by spi-nor
> framework to take care of handling vmalloc'd buffers which may not be
> DMA'able.
> 
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
>  drivers/mtd/devices/m25p80.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index c4df3b1bded0..d05acf22eadf 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -241,6 +241,7 @@ static int m25p_probe(struct spi_device *spi)
>  	else
>  		flash_name = spi->modalias;
>  
> +	nor->flags |= SNOR_F_USE_BOUNCE_BUFFER;

Isn't there a better way to detect whether a bounce buffer is needed or not?

Thanks,
//richard

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/2] mtd: spi-nor: Handle vmalloc'd buffers Vignesh R <vigneshr@ti.com> - 2017-02-27 13:20 +0100
  [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce buffer support Vignesh R <vigneshr@ti.com> - 2017-02-27 13:20 +0100
    Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Richard Weinberger <richard@nod.at> - 2017-02-28 22:50 +0100
      Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Vignesh R <vigneshr@ti.com> - 2017-03-01 09:00 +0100
        Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-03-01 12:10 +0100
          Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Frode Isaksen <fisaksen@baylibre.com> - 2017-03-01 12:50 +0100
          Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-01 13:40 +0100
          Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-01 15:30 +0100
            Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-03-01 15:40 +0100
          Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-03-01 15:30 +0100
            Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Mark Brown <broonie@kernel.org> - 2017-03-01 17:00 +0100
          Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-01 17:20 +0100
          Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-01 18:00 +0100
            Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Frode Isaksen <fisaksen@baylibre.com> - 2017-03-02 10:10 +0100
              Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-02 16:00 +0100
                Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Frode Isaksen <fisaksen@baylibre.com> - 2017-03-02 16:20 +0100
                Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-02 17:00 +0100
                Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Frode Isaksen <fisaksen@baylibre.com> - 2017-03-03 10:10 +0100
                Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-03-02 17:50 +0100
                Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Mark Brown <broonie@kernel.org> - 2017-03-02 19:20 +0100
                Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-03 04:20 +0100
                Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Mark Brown <broonie@kernel.org> - 2017-03-03 14:20 +0100
                Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Vignesh R <vigneshr@ti.com> - 2017-03-06 12:50 +0100
              Re: [RFC PATCH 2/2] mtd: devices: m25p80: Enable spi-nor bounce  buffer support Vignesh R <vigneshr@ti.com> - 2017-03-03 23:10 +0100
  [RFC PATCH 1/2] mtd: spi-nor: Introduce bounce buffer to handle vmalloc'd buffers Vignesh R <vigneshr@ti.com> - 2017-02-27 13:20 +0100
    Re: [RFC PATCH 1/2] mtd: spi-nor: Introduce bounce buffer to handle  vmalloc'd buffers Richard Weinberger <richard@nod.at> - 2017-03-01 02:50 +0100
      Re: [RFC PATCH 1/2] mtd: spi-nor: Introduce bounce buffer to handle  vmalloc'd buffers Vignesh R <vigneshr@ti.com> - 2017-03-01 09:00 +0100
      Re: [RFC PATCH 1/2] mtd: spi-nor: Introduce bounce buffer to handle  vmalloc'd buffers Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-03-01 11:20 +0100
        Re: [RFC PATCH 1/2] mtd: spi-nor: Introduce bounce buffer to handle  vmalloc'd buffers Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-01 12:00 +0100
          Re: [RFC PATCH 1/2] mtd: spi-nor: Introduce bounce buffer to handle  vmalloc'd buffers Frode Isaksen <fisaksen@baylibre.com> - 2017-03-01 12:30 +0100
            Re: [RFC PATCH 1/2] mtd: spi-nor: Introduce bounce buffer to handle  vmalloc'd buffers Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-01 13:40 +0100
        Re: [RFC PATCH 1/2] mtd: spi-nor: Introduce bounce buffer to handle  vmalloc'd buffers Vignesh R <vigneshr@ti.com> - 2017-03-01 13:00 +0100
  Re: [RFC PATCH 0/2] mtd: spi-nor: Handle vmalloc'd buffers Frode Isaksen <fisaksen@baylibre.com> - 2017-02-27 17:00 +0100

csiph-web