Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589761

Re: [PATCH 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT

Show all headers | View raw

On Tue, Feb 28, 2017 at 3:43 PM, Rafał Miłecki <zajec5@gmail.com> wrote:
> On 28 February 2017 at 21:31, Jon Mason <jon.mason@broadcom.com> wrote:
>> @@ -70,10 +70,19 @@
>>                         clocks = <&periph_clk>;
>>                 };
>>
>> -               local-timer@20600 {
>> +               timer@20600 {
>
> Is there a reason for this rename? I don't really have preference for
> any name, it's just we shouldn't keep renaming this depending of
> personal preferences.
>
> It also doesn't seem like adjusting to any schema:
> bcm63138.dtsi uses local-timer@1e600
> bcm-nsp.dtsi uses twd-timer@20600
> berlin2cd.dtsi uses local-timer@ad0600
> berlin2.dtsi uses local-timer@ad0600
> berlin2q.dtsi uses local-timer@ad0600

This was a suggestion from Sergei Shtylyov
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/395160.html


>
>>                         compatible = "arm,cortex-a9-twd-timer";
>> -                       reg = <0x20600 0x100>;
>> -                       interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_HIGH>;
>> +                       reg = <0x20600 0x20>;
>> +                       interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) |
>> +                                                 IRQ_TYPE_LEVEL_HIGH)>;
>> +                       clocks = <&periph_clk>;
>> +               };
>
> The rest looks OK, thanks! :)
>
> --
> Rafał

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT Jon Mason <jon.mason@broadcom.com> - 2017-02-28 21:50 +0100
  Re: [PATCH 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT Rafał Miłecki <zajec5@gmail.com> - 2017-02-28 22:20 +0100

csiph-web