Re: [PATCH 0/4] fujitsu_init() cleanup

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/4] fujitsu_init() cleanup
Date	2017-02-28 16:00 +0100
Message-ID	<tfRpU-5QG-43@gated-at.bofh.it> (permalink)
References	(6 earlier) <tfL18-1He-25@gated-at.bofh.it> <tfLu9-1T9-1@gated-at.bofh.it> <tfOV3-4hi-11@gated-at.bofh.it> <tfQaw-51i-71@gated-at.bofh.it> <tfQDv-5uI-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Feb 28, 2017 at 4:01 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Tue, Feb 28, 2017 at 02:24:40PM +0100, Michał Kępień wrote:
>> > On Tue, Feb 28, 2017 at 09:33:28AM +0100, Micha?? K??pie?? wrote:
>> > > GregKH wrote:

>> Greg objected to that, arguing that there might be userspace
>> applications using these attributes under their current path.  I do not
>> know of such an application.  My question to Darren was thus: do we move
>> dock, lid and radios and rip the platform driver and platform device out
>> of fujitsu-laptop or should these attributes rather stay where they are?
>
> I would say just to leave them as-is, there's no harm in those 40 lines,
> and you really don't want to break someone's existing setup for no good
> reason.

Michał, from design point of view you can split it to two parts if
*makes sense* / *needed*: core and platform driver.

-- 
With Best Regards,
Andy Shevchenko

Thread

Re: [PATCH 0/4] fujitsu_init() cleanup Michał Kępień <kernel@kempniu.pl> - 2017-02-27 08:30 +0100
  Re: [PATCH 0/4] fujitsu_init() cleanup Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-28 09:10 +0100
    Re: [PATCH 0/4] fujitsu_init() cleanup Michał Kępień <kernel@kempniu.pl> - 2017-02-28 09:40 +0100
      Re: [PATCH 0/4] fujitsu_init() cleanup Jonathan Woithe <jwoithe@just42.net> - 2017-02-28 13:20 +0100
        Re: [PATCH 0/4] fujitsu_init() cleanup Michał Kępień <kernel@kempniu.pl> - 2017-02-28 14:40 +0100
          Re: [PATCH 0/4] fujitsu_init() cleanup Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-28 15:10 +0100
            Re: [PATCH 0/4] fujitsu_init() cleanup Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-28 16:00 +0100
            Re: [PATCH 0/4] fujitsu_init() cleanup Darren Hart <dvhart@infradead.org> - 2017-03-01 04:30 +0100
    Re: [PATCH 0/4] fujitsu_init() cleanup Jonathan Woithe <jwoithe@just42.net> - 2017-02-28 12:30 +0100
      Re: [PATCH 0/4] fujitsu_init() cleanup Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-28 13:40 +0100
  Re: [PATCH 0/4] fujitsu_init() cleanup Darren Hart <dvhart@infradead.org> - 2017-02-28 09:20 +0100

csiph-web