Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589510

Re: [PATCH 3/3] lib: add module support to linked list sorting tests

Show all headers | View raw

On Tue, Feb 28, 2017 at 2:06 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:

> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 90b2348777495b72..32363ae022e3282a 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1731,11 +1731,12 @@ config LKDTM
>         Documentation/fault-injection/provoke-crashes.txt
>
>  config TEST_LIST_SORT
> -       bool "Linked list sorting test"
> -       depends on DEBUG_KERNEL
> +       tristate "Linked list sorting test"
> +       depends on DEBUG_KERNEL || m

I don't see any other test code with a "DEBUG_KERNEL || m" dependency,
but several that are "DEBUG_KERNEL && m". Maybe we should just
force it to be a module like the others? If there are good reasons to
have it built-in, I'd just drop the "|| m" here.

     Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] lib: add module support to linked list sorting tests Geert Uytterhoeven <geert@linux-m68k.org> - 2017-02-28 14:10 +0100
  Re: [PATCH 3/3] lib: add module support to linked list sorting tests Arnd Bergmann <arnd@arndb.de> - 2017-02-28 15:40 +0100
    Re: [PATCH 3/3] lib: add module support to linked list sorting tests Geert Uytterhoeven <geert@linux-m68k.org> - 2017-02-28 15:50 +0100

csiph-web