Re: [PATCH] Drivers: hv: util: on deinit, don't wait the release event, if we shouldn't

From	Vitaly Kuznetsov <vkuznets@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Drivers: hv: util: on deinit, don't wait the release event, if we shouldn't
Date	2017-02-28 15:30 +0100
Message-ID	<tfQWR-5Cn-7@gated-at.bofh.it> (permalink)
References	<tfrF7-4Ql-27@gated-at.bofh.it> <tfPo6-4t2-5@gated-at.bofh.it> <tfPo6-4t2-3@gated-at.bofh.it> <tfPR7-4Up-1@gated-at.bofh.it> <tfPR7-4Up-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Vitaly Kuznetsov <vkuznets@redhat.com> writes:

> Dexuan Cui <decui@microsoft.com> writes:
>
>>> From: devel [...] On Behalf Of Dexuan Cui
>>> > > --- a/drivers/hv/hv_utils_transport.h
>>> > > +++ b/drivers/hv/hv_utils_transport.h
>>> > > @@ -32,6 +32,7 @@ struct hvutil_transport {
>>> > >     int mode;                           /* hvutil_transport_mode */
>>> > >     struct file_operations fops;        /* file operations */
>>> > >     struct miscdevice mdev;             /* misc device */
>>> > > +   bool   dev_opened;                  /* Is the device opened? */
>>> > >     struct cb_id cn_id;                 /* CN_*_IDX/CN_*_VAL */
>>> > >     struct list_head list;              /* hvt_list */
>>> > >     int (*on_msg)(void *, int);         /* callback on new user message */
>>> >
>>> > I think we can get away without introducing this new flag, e.g. if we
>>> > replace release_event with an atomic which will hold the state
>>> > (open/closed). This will also elimenate possible races above. I can try
>>> > prototyping a patch if you want me to.
>>> > --
>>> >   Vitaly
>>> 
>>> Thanks for offering the help! Please do. :-)
>>
>> BTW, IMO I found another potential issue:
>> In hvt_op_open -> hvt_reset -> kvp_on_reset(), I think we should call
>> init_completion() instead of complete()?
>>
>
> To me it looks like we can do better with something different from
> struct completion, I'll take a look later today.

Dexuan,

please take a look at the attached patch. After looking at the code
again it occured to me that it's going to be easier to move release wait
to the transport itself. Lightly tested.

Thanks!

-- 
  Vitaly

Thread

[PATCH] Drivers: hv: util: on deinit, don't wait the release event,  if we shouldn't Dexuan Cui <decui@microsoft.com> - 2017-02-27 12:30 +0100
  RE: [PATCH] Drivers: hv: util: on deinit, don't wait the release  event, if we shouldn't Stephen Hemminger <sthemmin@microsoft.com> - 2017-02-27 18:20 +0100
    RE: [PATCH] Drivers: hv: util: on deinit, don't wait the release  event, if we shouldn't Dexuan Cui <decui@microsoft.com> - 2017-02-28 03:40 +0100
  RE: [PATCH] Drivers: hv: util: on deinit, don't wait the release  event, if we shouldn't Dexuan Cui <decui@microsoft.com> - 2017-02-28 13:50 +0100
    RE: [PATCH] Drivers: hv: util: on deinit, don't wait the release  event, if we shouldn't Dexuan Cui <decui@microsoft.com> - 2017-02-28 14:20 +0100
      Re: [PATCH] Drivers: hv: util: on deinit, don't wait the release event, if we shouldn't Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-02-28 14:20 +0100
        Re: [PATCH] Drivers: hv: util: on deinit, don't wait the release event, if we shouldn't Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-02-28 15:30 +0100
          RE: [PATCH] Drivers: hv: util: on deinit, don't wait the release  event, if we shouldn't Dexuan Cui <decui@microsoft.com> - 2017-03-01 16:20 +0100
  Re: [PATCH] Drivers: hv: util: on deinit, don't wait the release event, if we shouldn't Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-02-28 14:00 +0100

csiph-web