Re: [PATCH 1/3] Revert "lib/test_sort.c: make it explicitly non-modular"

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] Revert "lib/test_sort.c: make it explicitly non-modular"
Date	Tue, 28 Feb 2017 15:30:01 +0100
Message-ID	<tfQWR-5Cn-17@gated-at.bofh.it> (permalink)
References	<tfPHr-4Pz-7@gated-at.bofh.it> <tfPR7-4Up-7@gated-at.bofh.it>
X-Original-To	Geert Uytterhoeven <geert@linux-m68k.org>, Andrew Morton <akpm@linux-foundation.org>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.35,219,1484035200"; d="scan'208";a="829333785"
Organization	Intel Finland Oy
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.22.5-1
MIME-Version	1.0
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	49
X-Original-Cc	Arnd Bergmann <arnd@arndb.de>, Paul Gortmaker <paul.gortmaker@windriver.com>, Shuah Khan <shuah@kernel.org>, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 28 Feb 2017 16:24:37 +0200
X-Original-Message-ID	<1488291877.20145.59.camel@linux.intel.com>
X-Original-References	<1488287219-15832-1-git-send-email-geert@linux-m68k.org> <1488287219-15832-2-git-send-email-geert@linux-m68k.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1589507

Show key headers only | View raw

On Tue, 2017-02-28 at 14:06 +0100, Geert Uytterhoeven wrote:
> This reverts commit 8893f519330bb073a49c5b4676fce4be6f1be15d.
> 
> It's very valuable to have modular tests, so you can run them just by
> insmodding the test modules, instead of needing a separate kernel that
> runs them at boot.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  lib/test_sort.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/test_sort.c b/lib/test_sort.c
> index 4db3911db50ace76..d389c1cc2f6cf795 100644
> --- a/lib/test_sort.c
> +++ b/lib/test_sort.c
> @@ -1,11 +1,8 @@
>  #include <linux/sort.h>
>  #include <linux/slab.h>
> -#include <linux/init.h>
> +#include <linux/module.h>
> 

>  
> -/*
> - * A simple boot-time regression test
> - * License: GPL
> - */
> +/* a simple boot-time regression test */

I would leave this piece as is now.

The rest is okay.

>  
>  #define TEST_LEN 1000
>  
> @@ -41,4 +38,6 @@ static int __init test_sort_init(void)
>  	kfree(a);
>  	return err;
>  }
> -subsys_initcall(test_sort_init);
> +
> +module_init(test_sort_init);
> +MODULE_LICENSE("GPL");

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Thread

[PATCH 1/3] Revert "lib/test_sort.c: make it explicitly non-modular" Geert Uytterhoeven <geert@linux-m68k.org> - 2017-02-28 14:20 +0100
  Re: [PATCH 1/3] Revert "lib/test_sort.c: make it explicitly  non-modular" Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-02-28 15:30 +0100
    Re: [PATCH 1/3] Revert "lib/test_sort.c: make it explicitly non-modular" Geert Uytterhoeven <geert@linux-m68k.org> - 2017-02-28 16:30 +0100

csiph-web