Re: [PATCH v3 11/25] ARM: dts: Add Actions Semi S500 and LeMaker Guitar

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 11/25] ARM: dts: Add Actions Semi S500 and LeMaker Guitar
Date	2017-02-28 14:00 +0100
Message-ID	<tfPxM-4wA-9@gated-at.bofh.it> (permalink)
References	<tfJLI-GX-3@gated-at.bofh.it> <tfJVp-Kr-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On Tue, Feb 28, 2017 at 07:35:21AM +0100, Andreas Färber wrote:
> +/dts-v1/;
> +
> +#include "s500-guitar.dtsi"
> +
> +/ {
> +	compatible = "lemaker,guitar-bb-rev-b", "lemaker,guitar", "actions,s500";
> +	model = "LeMaker Guitar Base Board rev. B";
> +
> +	aliases {
> +		serial3 = &uart3;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial3:115200n8";
> +	};
> +};
> +
> +&uart3 {
> +	status = "okay";
> +};

> +#include "s500.dtsi"
> +
> +/ {
> +	compatible = "lemaker,guitar", "actions,s500";
> +
> +	/delete-node/ memory;

Eww. Is this just bodging around skeleton.dtsi?

> +
> +	memory@0 {
> +		device_type = "memory";
> +		reg = <0x0 0x40000000>;
> +	};
> +};

> +#include "skeleton.dtsi"

Please don't include skeleton.dtsi. Please add the relevant nodes and
properties explciitly to your dts{i,} files.

> +
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +/ {

Please define your #address-cells and #size-cells here.

If you want, add an empty /chosen node (not strictly necessary since
your dts file has a non-empty one anyhow).

Thanks,
Mark.

Thread

[PATCH v3 00/25] ARM: Initial Actions Semi S500 and S900 enablement Andreas Färber <afaerber@suse.de> - 2017-02-28 08:00 +0100
  [PATCH v3 11/25] ARM: dts: Add Actions Semi S500 and LeMaker Guitar Andreas Färber <afaerber@suse.de> - 2017-02-28 08:00 +0100
    Re: [PATCH v3 11/25] ARM: dts: Add Actions Semi S500 and LeMaker  Guitar Mark Rutland <mark.rutland@arm.com> - 2017-02-28 14:00 +0100
      Re: [PATCH v3 11/25] ARM: dts: Add Actions Semi S500 and LeMaker  Guitar Andreas Färber <afaerber@suse.de> - 2017-02-28 16:20 +0100
  [PATCH v3 06/25] ARM: Prepare Actions Semi S500 Andreas Färber <afaerber@suse.de> - 2017-02-28 08:00 +0100
  [PATCH v3 16/25] tty: serial: owl: Implement console driver Andreas Färber <afaerber@suse.de> - 2017-02-28 08:00 +0100
  [PATCH v3 09/25] tty: serial: Add Actions Semi Owl UART earlycon Andreas Färber <afaerber@suse.de> - 2017-02-28 08:00 +0100

csiph-web