Re: [PATCH v1 02/14] block: introduce bio_remove_last_page()

From	Ming Lei <tom.leiming@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 02/14] block: introduce bio_remove_last_page()
Date	2017-02-28 13:30 +0100
Message-ID	<tfP4J-4lm-5@gated-at.bofh.it> (permalink)
References	<teqi5-2bp-5@gated-at.bofh.it> <teqi6-2bp-35@gated-at.bofh.it> <tePgt-3lD-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Feb 26, 2017 at 2:23 AM, Christoph Hellwig <hch@infradead.org> wrote:
> On Fri, Feb 24, 2017 at 11:42:39PM +0800, Ming Lei wrote:
>> MD need this helper to remove the last added page, so introduce
>> it.
>
> If MD really has a valid use case for this it should open code the
> operation.  The semantics look deeply fishy to me.

Thinking about MD's case further, and looks bio_add_page() won't
fail at all in case that queue's limit isn't applied in bio_add_page()
in future.

So I will change MD's handling in this case and avoid to introduce
bio_remove_last_page() in V2.

Thanks,
Ming Lei

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 02/14] block: introduce bio_remove_last_page() Ming Lei <tom.leiming@gmail.com> - 2017-02-24 16:50 +0100
  Re: [PATCH v1 02/14] block: introduce bio_remove_last_page() Christoph Hellwig <hch@infradead.org> - 2017-02-25 19:30 +0100
    Re: [PATCH v1 02/14] block: introduce bio_remove_last_page() Ming Lei <tom.leiming@gmail.com> - 2017-02-28 13:30 +0100

csiph-web