Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1589360

[PATCH] scsi: qedi: fix missing return error code check on call to qedi_setup_int

From Colin King <colin.king@canonical.com>
Newsgroups linux.kernel
Subject [PATCH] scsi: qedi: fix missing return error code check on call to qedi_setup_int
Date 2017-02-28 12:10 +0100
Message-ID <tfNPj-3Bl-1@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


From: Colin Ian King <colin.king@canonical.com>

The call to qedi_setup_int is not updating the return code rc yet rc
is being checked for an error. Fix this by assigning rc to the return
code from the call to qedi_setup_int.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/scsi/qedi/qedi_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index 5eda21d..8e3d928 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -1805,7 +1805,7 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
 	 */
 	qedi_ops->common->update_pf_params(qedi->cdev, &qedi->pf_params);
 
-	qedi_setup_int(qedi);
+	rc = qedi_setup_int(qedi);
 	if (rc)
 		goto stop_iscsi_func;
 
-- 
2.10.2

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] scsi: qedi: fix missing return error code check on call to qedi_setup_int Colin King <colin.king@canonical.com> - 2017-02-28 12:10 +0100
  Re: [PATCH] scsi: qedi: fix missing return error code check on call  to qedi_setup_int "Rangankar, Manish" <Manish.Rangankar@cavium.com> - 2017-02-28 12:40 +0100
  Re: [PATCH] scsi: qedi: fix missing return error code check on call to qedi_setup_int "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-03-01 04:30 +0100

csiph-web