Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589298

Re: [PATCH 1/2] dt-bindings: iio: stm32-adc: add option to set resolution

Show all headers | View raw

On 02/28/2017 09:21 AM, Fabrice Gasnier wrote:
> On 02/25/2017 04:11 PM, Jonathan Cameron wrote:
>> On 24/02/17 16:04, Fabrice Gasnier wrote:
>>> On 02/19/2017 01:09 PM, Jonathan Cameron wrote:
>>>> On 15/02/17 16:55, Fabrice Gasnier wrote:
>>>>> Add documentation for 'st,adc-res' dt optional property.
>>>>>
>>>>> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
>>>> I'm happy with this, but would like to leave time for a device tree review.
>>>>
>>>> Ultimately we may well want to make this a generic property and call it
>>>> something
>>>> like adc-resolution but perhaps we need to wait until we have a few more
>>>> devices
>>>> supporting setting it via device tree to figure out what the best
>>>> interface is.
>>>> It would exactly be a problem to support this as a deprecated binding at
>>>> that
>>>> point.
>>>
>>> Hi Jonathan,
>>>
>>> I agree with you on this... It may be better to have generic property
>>> for this, especially if you see that it will come in the near future.
>>> May I suggest this prop to be less restrictive, e.g. like
>>> resolution-bits as is may also be worth for other device types, e.g.
>>> DAC as an example ?>
>> Sure, why not - no loss of meaning here.  We may never use it for anything
>> else but that doesn't matter.
> 
> Hi Jonathan,
> 
> Following Rob's comment, how you see such a common property can be
> integrated. Currently I don't see much devices are doing this.
> Do you have ideas or preferences on this ?
> 
> - Do you think replacing 'st,adc-res' by 'resolution-bits' in current
> patchset is enough for now ?

That name would be a bit confusing. Considering that the devicetree
describes th capabilities of the hardware this name would suggest that this
is the resolution supported by the device.

If we want to allow selecting runtime configuration parameters for IIO
devices from the devicetree we should probably follow the precedence set by
the clock framework and use properties with the 'assigned-' prefix.

But to be honest I'm not convinced yet that the whole approach of allowing
runtime configuration parameters to be configured via the devicetree is the
right approach. Converters and sensors often have a lot of runtime
configurable parameters, typically we expose them to the application layer
to allow maximum flexibility. Why is the resolution special in this case and
should be pre-configured via the devicetree instead?

- Lars

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] iio: allow to set STM32 ADC resolution  Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-02-15 18:00 +0100
  [PATCH 1/2] dt-bindings: iio: stm32-adc: add option to set resolution Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-02-15 18:00 +0100
    Re: [PATCH 1/2] dt-bindings: iio: stm32-adc: add option to set  resolution Jonathan Cameron <jic23@kernel.org> - 2017-02-19 13:20 +0100
      Re: [PATCH 1/2] dt-bindings: iio: stm32-adc: add option to set  resolution Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-02-24 17:50 +0100
        Re: [PATCH 1/2] dt-bindings: iio: stm32-adc: add option to set  resolution Jonathan Cameron <jic23@kernel.org> - 2017-02-25 16:20 +0100
          Re: [PATCH 1/2] dt-bindings: iio: stm32-adc: add option to set  resolution Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-02-28 09:30 +0100
            Re: [PATCH 1/2] dt-bindings: iio: stm32-adc: add option to set  resolution Lars-Peter Clausen <lars@metafoo.de> - 2017-02-28 10:10 +0100
              Re: [PATCH 1/2] dt-bindings: iio: stm32-adc: add option to set  resolution Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-02-28 12:50 +0100
        Re: [PATCH 1/2] dt-bindings: iio: stm32-adc: add option to set  resolution Rob Herring <robh@kernel.org> - 2017-02-27 16:30 +0100
  [PATCH 2/2] iio: adc: stm32: add dt option to set resolution Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-02-15 18:00 +0100
    Re: [PATCH 2/2] iio: adc: stm32: add dt option to set resolution Jonathan Cameron <jic23@kernel.org> - 2017-02-19 13:20 +0100

csiph-web