Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589301

Re: [PATCH] pinctrl: samsung: Calculate GPIO base for pinctrl_add_gpio_range

Show all headers | View raw

On Mon, Feb 27, 2017 at 11:13:59AM +0900, Tomasz Figa wrote:
> > diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
> > index ddc8d6b..864d8b4d 100644
> > --- a/drivers/pinctrl/samsung/pinctrl-samsung.c
> > +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
> > @@ -882,7 +882,7 @@ static int samsung_pinctrl_register(struct platform_device *pdev,
> >                 pin_bank->grange.id = bank;
> >                 pin_bank->grange.pin_base = drvdata->pin_base
> >                                                 + pin_bank->pin_base;
> > -               pin_bank->grange.base = pin_bank->gpio_chip.base;
> > +               pin_bank->grange.base = pin_bank->grange.pin_base;
> 
> If we are not reading the base from the GPIO bank anymore, maybe it
> could make sense to actually make samsung_gpiolib_register() use
> bank->grange.base as gc->base? This way we would avoid explicitly
> numbering two times.
> 

Yeah no problem I can respin with that included.

Thanks,
Charles

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/4] pinctrl: Fix trivial spelling typo in a comment Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-02-16 14:30 +0100
  [PATCH v2 4/4] pinctrl: samsung: Use devres version of gpiochip_add_data Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-02-16 14:30 +0100
    Re: [PATCH v2 4/4] pinctrl: samsung: Use devres version of  gpiochip_add_data Krzysztof Kozlowski <krzk@kernel.org> - 2017-02-17 14:40 +0100
      Re: [PATCH v2 4/4] pinctrl: samsung: Use devres version of  gpiochip_add_data Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-02-17 15:00 +0100
  [PATCH v2 2/4] pinctrl: samsung: Register pinctrl before GPIO Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-02-16 14:30 +0100
    Re: [PATCH v2 2/4] pinctrl: samsung: Register pinctrl before GPIO Linus Walleij <linus.walleij@linaro.org> - 2017-02-22 15:40 +0100
      Re: [PATCH v2 2/4] pinctrl: samsung: Register pinctrl before GPIO Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-02-23 18:30 +0100
        [PATCH] pinctrl: samsung: Calculate GPIO base for pinctrl_add_gpio_range Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-02-23 19:00 +0100
          Re: [PATCH] pinctrl: samsung: Calculate GPIO base for pinctrl_add_gpio_range Tomasz Figa <tomasz.figa@gmail.com> - 2017-02-27 03:20 +0100
            Re: [PATCH] pinctrl: samsung: Calculate GPIO base for  pinctrl_add_gpio_range Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-02-28 10:10 +0100
              [PATCH v2] pinctrl: samsung: Calculate GPIO base for pinctrl_add_gpio_range Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-02-28 18:30 +0100

csiph-web