Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1589239
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v6] staging: xgifb: correct the multiple line dereference |
| Date | 2017-02-28 08:10 +0100 |
| Message-ID | <tfK54-12X-5@gated-at.bofh.it> (permalink) |
| References | <tfImB-8dY-3@gated-at.bofh.it> <tfJ8Z-qK-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 2017-02-28 at 06:51 +0100, Greg Kroah-Hartman wrote: > On Tue, Feb 28, 2017 at 10:35:30AM +0530, Arushi Singhal wrote: > > Error reported by checkpatch.pl as "avoid multiple line dereference". > > Addition of new variables to make the code more readable and also to > > correct about mentioned error as by itroducing new variables line is > > not exceeding 80 characters. [] > Remember, coding style cleanups are to be done to make the code easier > to understand and follow. Not to blindly follow a perl script that > can not think. Sometimes it is not right... Yeah, what Greg said. Also very long identifier names like RefreshRateTableIndex and simple dereferences like XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag make using 80 columns silly. Just ignore 80 column limits when there are 20+ character identifiers. Ideally shorten the identifiers to something less verbose and/or use temporaries where appropriate like I showed in my reply to your suggested V5 patch.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v6] staging: xgifb: correct the multiple line dereference Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-02-28 06:20 +0100
Re: [PATCH v6] staging: xgifb: correct the multiple line dereference Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-28 07:10 +0100
Re: [PATCH v6] staging: xgifb: correct the multiple line dereference Joe Perches <joe@perches.com> - 2017-02-28 08:10 +0100
Re: [Outreachy kernel] Re: [PATCH v6] staging: xgifb: correct the multiple line dereference Julia Lawall <julia.lawall@lip6.fr> - 2017-02-28 09:50 +0100
Re: [PATCH v6] staging: xgifb: correct the multiple line dereference Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-28 11:40 +0100
csiph-web