Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1589232
| From | Cyrill Gorcunov <gorcunov@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC 2/3] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files |
| Date | 2017-02-28 08:00 +0100 |
| Message-ID | <tfJVp-Kr-39@gated-at.bofh.it> (permalink) |
| References | <tdmgx-5z4-15@gated-at.bofh.it> <tfJVq-Kr-41@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Feb 27, 2017 at 02:43:47PM -0800, Andrei Vagin wrote:
...
> > +
> > + if (filp1 && filp_epoll) {
> > + filp_tgt = get_epoll_tfile_raw_ptr(filp_epoll, slot.tfd, slot.toff);
> > + if (IS_ERR(filp_tgt))
> > + ret = PTR_ERR(filp_tgt);
> > + else
> > + ret = kcmp_ptr(filp1, filp_tgt, KCMP_EPOLL_TFD);
>
> I think KCMP_FILE has to be used here ^^^^, because we compare files. We
> have to use the same function for all files to be able to sort them, don't we?
Yes. I already have v2 in my queue. Strictly speaking we can use separate
salt here but it will be waste of memory from userspace POV. I didn't send
v2 yet since I'm modifying criu still to test overall picture. Hopefully
will send today.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC 2/3] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files Cyrill Gorcunov <gorcunov@openvz.org> - 2017-02-21 18:20 +0100
Re: [RFC 2/3] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files Cyrill Gorcunov <gorcunov@gmail.com> - 2017-02-28 08:00 +0100
[RFC v2 2/3] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files Cyrill Gorcunov <gorcunov@gmail.com> - 2017-02-28 18:20 +0100
csiph-web