Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1589142
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] sd: close hole in > 2T device rejection when !CONFIG_LBDAF |
| Date | 2017-02-28 04:30 +0100 |
| Message-ID | <tfGE9-6YX-3@gated-at.bofh.it> (permalink) |
| References | <tfvz4-7vd-11@gated-at.bofh.it> <tfx7Q-gn-21@gated-at.bofh.it> <tfx7Q-gn-19@gated-at.bofh.it> <tfGE9-6YX-5@gated-at.bofh.it> |
| Organization | Oracle Corporation |
>>>>> "Bart" == Bart Van Assche <Bart.VanAssche@sandisk.com> writes: Bart, Bart> Sorry but I still don't understand why the two checks are Bart> different. How about the (untested) patch below? The approach Bart> below avoids that the check is duplicated and - at least in my Bart> opinion - results in code that is easier to read. I'll take a closer look at your patch tomorrow. I am sympathetic to having a sanity check helper function. That would also give us a single place to filter out crackpot values reported by USB doodads. -- Martin K. Petersen Oracle Linux Engineering
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] sd: close hole in > 2T device rejection when !CONFIG_LBDAF "Steven J. Magnani" <steve.magnani@digidescorp.com> - 2017-02-27 16:40 +0100
Re: [PATCH] sd: close hole in > 2T device rejection when !CONFIG_LBDAF Steve Magnani <steve.magnani@digidescorp.com> - 2017-02-27 18:20 +0100
Re: [PATCH] sd: close hole in > 2T device rejection when !CONFIG_LBDAF "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-02-28 04:30 +0100
Re: [PATCH] sd: close hole in > 2T device rejection when !CONFIG_LBDAF Steve Magnani <steve.magnani@digidescorp.com> - 2017-02-28 15:00 +0100
csiph-web