Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589115

Re: [PATCH 0/2] key payload access with just rcu_read_lock()

Show all headers | View raw

----- Original Message -----
> From: "David Howells" <dhowells@redhat.com>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, bcodding@redhat.com,
> asavkov@redhat.com
> Sent: Monday, 27 February, 2017 11:04:21 PM
> Subject: Re: [PATCH 0/2] key payload access with just rcu_read_lock()
> 
> Jan Stancek <jstancek@redhat.com> wrote:
> 
> > this is a follow-up for "suspicious RCU usage" warning described
> > in these 2 linux-nfs threads:
> >   http://marc.info/?t=147558830300003&r=1&w=2
> >   http://marc.info/?t=148776770500001&r=1&w=2
> > 
> > Did you have something like in mind?
> 
> How about the attached?  It's similar to what you did, but I made the split
> functions different from the original so that all users have to reconsider
> what they actually want.
> 
> David

Looks like there are still couple users that need updating,
I'm hitting following compilation error:

...
  CC [M]  fs/cifs/connect.o
fs/cifs/connect.c: In function ‘cifs_set_cifscreds’:
fs/cifs/connect.c:2442:2: error: implicit declaration of function ‘user_key_payload’ [-Werror=implicit-function-declaration]
  upayload = user_key_payload(key);
  ^
fs/cifs/connect.c:2442:11: error: assignment makes pointer from integer without a cast [-Werror]
  upayload = user_key_payload(key);
           ^

# grep "user_key_payload(" -r . --include=*.c
./drivers/md/dm-crypt.c:        ukp = user_key_payload(key);
./fs/cifs/connect.c:    upayload = user_key_payload(key);
./fs/crypto/keyinfo.c:  ukp = user_key_payload(keyring_key);
./lib/digsig.c: ukp = user_key_payload(key);

# grep "user_key_payload(" -r . --include=*.h
./fs/ecryptfs/ecryptfs_kernel.h:                return (struct ecryptfs_auth_tok *)user_key_payload(key)->data;

Regards,
Jan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] key payload access with just rcu_read_lock() Jan Stancek <jstancek@redhat.com> - 2017-02-23 00:00 +0100
  [PATCH 2/2] NFS: use user_key_payload_rcu() in RCU read-side section Jan Stancek <jstancek@redhat.com> - 2017-02-23 00:00 +0100
  [PATCH 1/2] KEYS: add user_key_payload_rcu() Jan Stancek <jstancek@redhat.com> - 2017-02-23 00:00 +0100
  Re: [PATCH 0/2] key payload access with just rcu_read_lock() David Howells <dhowells@redhat.com> - 2017-02-27 23:10 +0100
    Re: [PATCH 0/2] key payload access with just rcu_read_lock() David Howells <dhowells@redhat.com> - 2017-02-28 02:20 +0100
      Re: [PATCH 0/2] key payload access with just rcu_read_lock() Jan Stancek <jstancek@redhat.com> - 2017-02-28 10:20 +0100
      Re: [PATCH 0/2] key payload access with just rcu_read_lock() David Howells <dhowells@redhat.com> - 2017-02-28 11:30 +0100
        Re: [PATCH 0/2] key payload access with just rcu_read_lock() Jan Stancek <jstancek@redhat.com> - 2017-02-28 15:30 +0100
    Re: [PATCH 0/2] key payload access with just rcu_read_lock() Jan Stancek <jstancek@redhat.com> - 2017-02-28 03:40 +0100

csiph-web