Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589026

Re: [PATCH v2 3/3] media: dt-bindings: vpif: new optional property

Show all headers | View raw

On Wed, Feb 22, 2017 at 02:43:47PM +0100, Bartosz Golaszewski wrote:
> Add an optional property - enable-gpios - which can be used to specify
> the GPIOs that must be requested to select the vpif functionality.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
>  Documentation/devicetree/bindings/media/ti,da850-vpif.txt | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> index df7182a..23c5405 100644
> --- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> @@ -13,6 +13,9 @@ Required properties:
>  - reg: physical base address and length of the registers set for the device;
>  - interrupts: should contain IRQ line for the VPIF
>  
> +Optional properties:
> +- enable-gpios: phandle of the GPIOs used to select the vpif functionality

What does this control exactly? The GPIOs belong in the node they are 
connected to and having GPIOs routed to this block seems strange.

There are inputs or outputs?

> +
>  Video Capture:
>  
>  VPIF has a 16-bit parallel bus input, supporting 2 8-bit channels or a
> @@ -30,6 +33,10 @@ I2C-connected TVP5147 decoder:
>  		reg = <0x217000 0x1000>;
>  		interrupts = <92>;
>  
> +		enable-gpios = <&tca6416 7 GPIO_ACTIVE_HIGH
> +				&tca6416 6 GPIO_ACTIVE_HIGH
> +				&tca6416 5 GPIO_ACTIVE_LOW>;
> +
>  		port@0 {
>  			vpif_input_ch0: endpoint@0 {
>  				reg = <0>;
> -- 
> 2.9.3
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] media: dt-bindings: extend the vpif bindings Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-22 14:50 +0100
  [PATCH v2 3/3] media: dt-bindings: vpif: new optional property Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-22 14:50 +0100
    Re: [PATCH v2 3/3] media: dt-bindings: vpif: new optional property Rob Herring <robh@kernel.org> - 2017-02-28 00:00 +0100
      Re: [PATCH v2 3/3] media: dt-bindings: vpif: new optional property Sekhar Nori <nsekhar@ti.com> - 2017-02-28 06:40 +0100
        Re: [PATCH v2 3/3] media: dt-bindings: vpif: new optional property Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-28 13:00 +0100
        Re: [PATCH v2 3/3] media: dt-bindings: vpif: new optional property Rob Herring <robh@kernel.org> - 2017-02-28 15:30 +0100
  [PATCH v2 2/3] media: dt-bindings: vpif: extend the example with an output port Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-22 14:50 +0100
    Re: [PATCH v2 2/3] media: dt-bindings: vpif: extend the example with  an output port Rob Herring <robh@kernel.org> - 2017-02-28 00:00 +0100
  Re: [PATCH v2 0/3] media: dt-bindings: extend the vpif bindings Sekhar Nori <nsekhar@ti.com> - 2017-02-28 13:10 +0100

csiph-web