Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1588949

[PATCH] touchscreen: ad7879: include linux/property.h

Path csiph.com!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject [PATCH] touchscreen: ad7879: include linux/property.h
Date Mon, 27 Feb 2017 22:20:02 +0100
Message-ID <tfAS6-2SI-19@gated-at.bofh.it> (permalink)
X-Mailer git-send-email 2.9.0
X-Provags-ID V03:K0:Za2sQfpaQDmOC64xP3uQKmG+xD7ABODFNXu9SGLM8Du4SqCDKKW FT6Zz2nvnLW+RNNSM8enpdGz0aikKl9vHYN5s1Jb4evUCf7E3+CjOXj+pDn/uKOLQBanpha G2hZDqjN2jvNkF4acu1zqSJFZnPEMsDcpP63S9ec8qHL8O8GGtcSZ8UqmKVmFAf+CboCD0v +oTHWHDE5APilYbJ+e3Rg==
X-Ui-Out-Filterresults notjunk:1;V01:K0:aA1h6JrQFlQ=:YAp68VEMYqPMiv0YjrZtK8 wfiRwPVhWtHhKR2+rUrpBOM/jIBgNnnv8lOw3vhU4bp3Kd1WgiuUN90ydg00Z+xMJ71ygtMaq AqabbkfuktjcGGfCNqMd0fcl3LmuA7SI/Mp0lebVgbGvHChEJHik7Q0PacsdDE7uEB8mnQE0e dBs6/SzNH15r2/cSXnD0y5nr8ODG935tDN13U17/C2Yy/ySm+SEOJHPi6PruteaF60XHSfUKC 2cgYDchL27331JUick7gDtY1uBVDgDWVjMYToFyeiQ5RAUHOZiWNuPrPzr3VLdf/cpJJzZ9IK W8gDs+AOl3FsN2DshN3EJ/YceUtkDpbJo1YdieMWxaQFNKVg0sYmoGSWMV7gqJh4V4VzJaPa8 pvdC9EIRI1mHRIulR+QrB5y9AwudZCUH8iXfm0YWI045D/PmR6DZqxMUs/v3R1lmRJRkGeqf5 yJWb3I5KyZf9g8lu7pmSgTtVA2d3uw5MSIFZgOuV40hI2n14CRzOKDn+XE5iuY0wLCnH5YTa9 dygV/PLmbH1ZFUOus0/VgC2pLWughlSv4vh80DF3VksFkMQIua4yQi6vYF6FUWKJhOG7etq9k rwTgsersNqXmotXeD4ROYCu/eqVOFWcEr1BLZd77lRCRDibVOnvipH3Ua947puJyVmwe7by/0 QkTB7ekD2+KVpTJd5iZAJ43iFzrF+V5hDydPV2D/w9DEEzpeeDXCzXIoltwft8y5nZ6g=
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 33
Organization linux.* mail to news gateway
X-Original-Cc Arnd Bergmann <arnd@arndb.de>, Stefan Agner <stefan@agner.ch>, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Mon, 27 Feb 2017 21:39:40 +0100
X-Original-Message-ID <20170227203954.3489470-1-arnd@arndb.de>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1588949

Show key headers only | View raw


I ran into this build failure during randconfig testing:

drivers/input/touchscreen/ad7879.c: In function 'ad7879_parse_dt':
drivers/input/touchscreen/ad7879.c:505:8: error: implicit declaration of function 'device_property_read_u32'
drivers/input/touchscreen/ad7879.c:512:2: error: implicit declaration of function 'device_property_read_u8'
drivers/input/touchscreen/ad7879.c:521:16: error: implicit declaration of function 'device_property_read_bool'

I could not figure out when this was introduced, as the code doesn't
appear to have changed recently, but the fix of including the header
with the declaration is obvious.

The calls that require the extra header were introduced a year ago in
commit fa6e3ca27442 ("Input: ad7879 - add device tree support").

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/input/touchscreen/ad7879.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/touchscreen/ad7879.c b/drivers/input/touchscreen/ad7879.c
index 53ab689305ac..1bd870277e1a 100644
--- a/drivers/input/touchscreen/ad7879.c
+++ b/drivers/input/touchscreen/ad7879.c
@@ -26,6 +26,7 @@
 #include <linux/input.h>
 #include <linux/interrupt.h>
 #include <linux/irq.h>
+#include <linux/property.h>
 #include <linux/regmap.h>
 #include <linux/slab.h>
 #include <linux/gpio.h>
-- 
2.9.0

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] touchscreen: ad7879: include linux/property.h Arnd Bergmann <arnd@arndb.de> - 2017-02-27 22:20 +0100
  Re: [PATCH] touchscreen: ad7879: include linux/property.h Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-01 00:00 +0100

csiph-web