Re: [PATCH v5 6/7] arm64: dts: allwinner: add Allwinner H5 .dtsi

From	Rask Ingemann Lambertsen <rask@formelder.dk>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 6/7] arm64: dts: allwinner: add Allwinner H5 .dtsi
Date	2017-02-26 10:00 +0100
Message-ID	<tf2Qp-4l3-3@gated-at.bofh.it> (permalink)
References	<teYjL-1mm-3@gated-at.bofh.it> <tf2Qp-4l3-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Feb 26, 2017 at 09:19:55AM +0800, Icenowy Zheng wrote:
> From: Andre Przywara <andre.przywara@arm.com>
> 
> The Allwinner H5 SoC is pin-compatible to the H3 SoC, but uses
> Cortex-A53 cores instead.
> Based on the now shared base .dtsi describing the common peripherals
> describe the H5 specific nodes on top of that.
> That symlinks in the sunxi-h3-h5.dtsi from the arch/arm tree.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> [Icenowy: add H5 pinctrl compatible, and changes for my h3-h5 dtsi
>  refactor, commit message change to met new arm64 naming scheme,

s/change to met/change to meet/ or s/change to met/changed to meet/ ?

> diff --git a/arch/arm64/boot/dts/allwinner/sunxi-h3-h5.dtsi b/arch/arm64/boot/dts/allwinner/sunxi-h3-h5.dtsi
> new file mode 120000
> index 000000000000..036f01dc2b9b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sunxi-h3-h5.dtsi
> @@ -0,0 +1 @@
> +../../../../arm/boot/dts/sunxi-h3-h5.dtsi
> \ No newline at end of file

But it's missing more than just a newline, isn't it? Shouldn't it read

#include <../../../../arm/boot/dts/sunxi-h3-h5.dtsi>

?

-- 
Rask Ingemann Lambertsen

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 6/7] arm64: dts: allwinner: add Allwinner H5 .dtsi Rask Ingemann Lambertsen <rask@formelder.dk> - 2017-02-26 10:00 +0100
  Re: [PATCH v5 6/7] arm64: dts: allwinner: add Allwinner H5 .dtsi Chen-Yu Tsai <wens@csie.org> - 2017-02-26 10:20 +0100

csiph-web