Re: [PATCH v2 2/5] powerpc: kretprobes: override default function entry offset

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/5] powerpc: kretprobes: override default function entry offset
Date	2017-02-24 21:00 +0100
Message-ID	<teuc2-4Ze-15@gated-at.bofh.it> (permalink)
References	<tdFCx-2v3-3@gated-at.bofh.it> <tdFCy-2v3-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Wed, Feb 22, 2017 at 07:23:38PM +0530, Naveen N. Rao escreveu:
> With ABIv2, we offset 8 bytes into a function to get at the local entry
> point.

So, I think I can carry the first one via Ingo, etc, what about this
one?

Is it ok for me to process it?

Seems simple enough, has been thru a lot of discussion, but would be
better if it was Reviewed-by the PPC maintainers or else just processed
by them.

Please advise,

- Arnaldo
 
> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> ---
>  arch/powerpc/kernel/kprobes.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/powerpc/kernel/kprobes.c b/arch/powerpc/kernel/kprobes.c
> index 735ff3d3f77d..e37b76b8b6b2 100644
> --- a/arch/powerpc/kernel/kprobes.c
> +++ b/arch/powerpc/kernel/kprobes.c
> @@ -131,6 +131,15 @@ static void __kprobes set_current_kprobe(struct kprobe *p, struct pt_regs *regs,
>  	kcb->kprobe_saved_msr = regs->msr;
>  }
>  
> +bool arch_function_offset_within_entry(unsigned long offset)
> +{
> +#ifdef PPC64_ELF_ABI_v2
> +	return offset <= 8;
> +#else
> +	return !offset;
> +#endif
> +}
> +
>  void __kprobes arch_prepare_kretprobe(struct kretprobe_instance *ri,
>  				      struct pt_regs *regs)
>  {
> -- 
> 2.11.0

Thread

[PATCH v2 2/5] powerpc: kretprobes: override default function entry offset "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2017-02-22 15:00 +0100
  Re: [PATCH v2 2/5] powerpc: kretprobes: override default function  entry offset Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-02-24 21:00 +0100
    Re: [PATCH v2 2/5] powerpc: kretprobes: override default function entry offset Michael Ellerman <mpe@ellerman.id.au> - 2017-02-27 20:00 +0100
  Re: [PATCH v2 2/5] powerpc: kretprobes: override default function  entry offset Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com> - 2017-02-25 03:50 +0100

csiph-web