Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1587838

Re: [PATCH 2/8] watchdog: s3c2410: Fix infinite interrupt in soft mode

Show all headers | View raw

On Fri, Feb 24, 2017 at 07:37:53AM -0800, Guenter Roeck wrote:
> On 02/24/2017 07:11 AM, Krzysztof Kozlowski wrote:
> > In soft (no-reboot) mode, the driver self-pings watchdog upon expiration
> > of an interrupt.  However the interrupt itself was not cleared thus on
> > first hit, the system enters infinite interrupt handling loop.
> > 
> > On Odroid U3 (Exynos4412), when booted with s3c2410_wdt.soft_noboot=1
> > argument the console is flooded:
> > 	# killall -9 watchdog
> > 	[   60.523760] s3c2410-wdt 10060000.watchdog: watchdog timer expired (irq)
> > 	[   60.536744] s3c2410-wdt 10060000.watchdog: watchdog timer expired (irq)
> > 
> > Fix this by writing something to the WTCLRINT register to clear the
> > interrupt.  The register WTCLRINT however appeared in S3C6410 so a new
> > watchdog quirk and flavor are needed.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
> > 
> > ---
> > 
> > I was thinking about CC-ing stable, especially when I thought about
> > adding unconditional WTCLRINT clear.  However it appears that S3C2410
> > does not have the WTCLRINT register, this a new chip flavor has to be
> > added.  This makes the fix spread over driver and DTS changes.
> > 
> > Worth adding:
> > 	Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > ?
> 
> How would that be different to Cc: stable ?

I guess not much... except for the metrics that some bug was fixed.

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] watchdog: s3c2410: Fixes and improvements Krzysztof Kozlowski <krzk@kernel.org> - 2017-02-24 16:20 +0100
  [PATCH 5/8] ARM: dts: exynos: Enable watchdog on all Exynos4 boards Krzysztof Kozlowski <krzk@kernel.org> - 2017-02-24 16:30 +0100
  Re: [PATCH 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 Krzysztof Kozlowski <krzk@kernel.org> - 2017-02-24 16:30 +0100
  [PATCH 1/8] watchdog: s3c2410: Remove confusing CONFIG prefix from local defines Krzysztof Kozlowski <krzk@kernel.org> - 2017-02-24 16:30 +0100
    Re: [PATCH 1/8] watchdog: s3c2410: Remove confusing CONFIG prefix  from local defines Guenter Roeck <linux@roeck-us.net> - 2017-02-24 16:40 +0100
  [PATCH 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 Krzysztof Kozlowski <krzk@kernel.org> - 2017-02-24 16:30 +0100
  [PATCH 8/8] ARM: dts: s5pv210: Fix infinite interrupt in soft mode Krzysztof Kozlowski <krzk@kernel.org> - 2017-02-24 16:30 +0100
  [PATCH 7/8] ARM: dts: s3c64xx: Fix infinite interrupt in soft mode Krzysztof Kozlowski <krzk@kernel.org> - 2017-02-24 16:30 +0100
  [PATCH 2/8] watchdog: s3c2410: Fix infinite interrupt in soft mode Krzysztof Kozlowski <krzk@kernel.org> - 2017-02-24 16:30 +0100
    Re: [PATCH 2/8] watchdog: s3c2410: Fix infinite interrupt in soft  mode Guenter Roeck <linux@roeck-us.net> - 2017-02-24 16:40 +0100
      Re: [PATCH 2/8] watchdog: s3c2410: Fix infinite interrupt in soft  mode Krzysztof Kozlowski <krzk@kernel.org> - 2017-02-24 18:50 +0100
    Re: [PATCH 2/8] watchdog: s3c2410: Fix infinite interrupt in soft  mode Rob Herring <robh@kernel.org> - 2017-02-28 05:10 +0100
  [PATCH 4/8] ARM: dts: s3c64xx: Enable watchdog on all S3C64xx boards Krzysztof Kozlowski <krzk@kernel.org> - 2017-02-24 16:30 +0100
  [PATCH 6/8] ARM: dts: exynos: Fix infinite interrupt in soft mode on Exynos5440 Krzysztof Kozlowski <krzk@kernel.org> - 2017-02-24 16:30 +0100

csiph-web