Re: [PATCH] staging: vc04_services: Fixed "space prohibited after that open/close parenthesis" erros.

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: vc04_services: Fixed "space prohibited after that open/close parenthesis" erros.
Date	2017-02-24 18:50 +0100
Message-ID	<tesad-3vj-5@gated-at.bofh.it> (permalink)
References	<te2IO-2vk-9@gated-at.bofh.it> <te69I-4Vi-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Feb 23, 2017 at 10:15:55AM -0800, Joe Perches wrote:
> On Thu, 2017-02-23 at 20:00 +0530, Yamanappagouda Patil wrote:
> > Fixed checkpath.pl erros "space prohibited after that open/close parenthesis" in vchiq_version.c file.
> > 
> > Signed-off-by: Yamanappagouda Patil <goudapatilk@gmail.com>
> > ---
> >  .../vc04_services/interface/vchiq_arm/vchiq_version.c    | 16 ++++++++--------
> >  1 file changed, 8 insertions(+), 8 deletions(-)
> > 
> > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c
> []
> > @@ -33,27 +33,27 @@
> >  #include "vchiq_build_info.h"
> >  #include <linux/broadcom/vc_debug_sym.h>
> >  
> > -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_hostname, "dc4-arm-01" );
> > -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_version, "9245b4c35b99b3870e1f7dc598c5692b3c66a6f0 (tainted)" );
> > -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_time,    __TIME__ );
> > -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_date,    __DATE__ );
> > +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_hostname, "dc4-arm-01");
> > +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_version, "9245b4c35b99b3870e1f7dc598c5692b3c66a6f0 (tainted)");
> > +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_time,    __TIME__);
> > +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_date,    __DATE__);
> 
> Uses of __TIME__ and __DATE__ make it
> impossible to have repeatable builds.
> 
> Are these __TIME__ and __DATE__ uses
> really useful and necessary?

No, they need to be removed, but not in this patch :)

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: vc04_services: Fixed "space prohibited after that open/close parenthesis" erros. Yamanappagouda Patil <goudapatilk@gmail.com> - 2017-02-23 15:40 +0100
  Re: [PATCH] staging: vc04_services: Fixed "space prohibited after  that open/close parenthesis" erros. Joe Perches <joe@perches.com> - 2017-02-23 19:20 +0100
    Re: [PATCH] staging: vc04_services: Fixed "space prohibited after  that open/close parenthesis" erros. Greg KH <gregkh@linuxfoundation.org> - 2017-02-24 18:50 +0100

csiph-web