Re: [PATCH] remove unnecessary initial allocation of vc

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] remove unnecessary initial allocation of vc
Date	2017-02-24 18:40 +0100
Message-ID	<tes0x-3rI-9@gated-at.bofh.it> (permalink)
References	<tdjiF-3At-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Feb 21, 2017 at 07:33:32PM +0530, Pranay Kr. Srivastava wrote:
> This patch removes the unnecessary allocation of
> current foreground vc during initialization.
> 
> Also change the prototype of speakup_allocate to take
> extra argument of gfp_* flags. Thus not requiring
> GFP_ATOMIC during initialization.

That's two different things, please do this in two different patches.

And always say what driver/subsystem you are patching in your subject
line, like other patches for the same driver.

Please fix up and resend.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] remove unnecessary initial allocation of vc "Pranay Kr. Srivastava" <pranjas@gmail.com> - 2017-02-21 15:10 +0100
  Re: [PATCH] remove unnecessary initial allocation of vc Samuel Thibault <samuel.thibault@ens-lyon.org> - 2017-02-21 15:20 +0100
  Re: [PATCH] remove unnecessary initial allocation of vc Greg KH <gregkh@linuxfoundation.org> - 2017-02-24 18:40 +0100

csiph-web