Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1587807

Re: [PATCH V4 6/6] proc: show MADV_FREE pages info in smaps

Show all headers | View raw

On 02/22/2017 10:50 AM, Shaohua Li wrote:
> @@ -770,6 +774,7 @@ static int show_smap(struct seq_file *m, void *v, int is_pid)
>  		   "Private_Dirty:  %8lu kB\n"
>  		   "Referenced:     %8lu kB\n"
>  		   "Anonymous:      %8lu kB\n"
> +		   "LazyFree:       %8lu kB\n"
>  		   "AnonHugePages:  %8lu kB\n"
>  		   "ShmemPmdMapped: %8lu kB\n"
>  		   "Shared_Hugetlb: %8lu kB\n"

I've been as guily of this in the past as anyone, but are we just going
to keep adding fields to smaps forever?  For the vast, vast, majority of
folks, this will simply waste the 21 bytes * nr_vmas that it costs us to
print "LazyFree:       0 kB\n" over and over.

Should we maybe start a habit of not printing an entry when it's "0 kB"?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V4 6/6] proc: show MADV_FREE pages info in smaps Shaohua Li <shli@fb.com> - 2017-02-22 20:00 +0100
  Re: [PATCH V4 6/6] proc: show MADV_FREE pages info in smaps Johannes Weiner <hannes@cmpxchg.org> - 2017-02-23 17:30 +0100
  Re: [PATCH V4 6/6] proc: show MADV_FREE pages info in smaps Minchan Kim <minchan@kernel.org> - 2017-02-24 03:20 +0100
  Re: [PATCH V4 6/6] proc: show MADV_FREE pages info in smaps Dave Hansen <dave.hansen@intel.com> - 2017-02-24 18:10 +0100

csiph-web