Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1587783

Re: [PATCH net] rxrpc: Fix an assertion in rxrpc_read()

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH net] rxrpc: Fix an assertion in rxrpc_read()
Date 2017-02-24 17:40 +0100
Message-ID <ter4v-2Kh-27@gated-at.bofh.it> (permalink)
References <tenke-7b-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: David Howells <dhowells@redhat.com>
Date: Fri, 24 Feb 2017 12:33:09 +0000

> From: Marc Dionne <marc.dionne@auristor.com>
> 
> In the rxrpc_read() function, which allows a user to read the contents of a
> key, we miscalculate the expected length of an encoded rxkad token by not
> taking into account the key length.  However, the data is stored later
> anyway with an ENCODE_DATA() call - and an assertion failure then ensues
> when the lengths are checked at the end.
> 
> Fix this by including the key length in the token size estimation.
> 
> The following assertion is produced:
 ...
> Signed-off-by: Marc Dionne <marc.dionne@auristor.com>
> Signed-off-by: David Howells <dhowells@redhat.com>

Applied.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH net] rxrpc: Fix an assertion in rxrpc_read() David Howells <dhowells@redhat.com> - 2017-02-24 13:40 +0100
  Re: [PATCH net] rxrpc: Fix an assertion in rxrpc_read() David Miller <davem@davemloft.net> - 2017-02-24 17:40 +0100

csiph-web