Re: [PATCH v7 1/2] staging: wlan-ng: move else if statement to a single line

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 1/2] staging: wlan-ng: move else if statement to a single line
Date	2017-02-24 17:40 +0100
Message-ID	<ter4u-2Kh-7@gated-at.bofh.it> (permalink)
References	<tb9ns-1Ak-19@gated-at.bofh.it> <tb9x8-1Fk-19@gated-at.bofh.it> <tbyYz-1KY-33@gated-at.bofh.it> <tbRRw-5tj-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Feb 17, 2017 at 09:33:01AM -0500, Maksymilian Piechota wrote:
> On Thu, Feb 16, 2017 at 10:27:24AM -0800, Greg Kroah-Hartman wrote:
> > On Wed, Feb 15, 2017 at 10:11:00AM -0500, Maksymilian Piechota wrote:
> > > move else if statement to a single line
> > > 
> > > Signed-off-by: Maksymilian Piechota <maksymilianpiechota@gmail.com>
> > > ---
> > >  drivers/staging/wlan-ng/prism2mgmt.c | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> > > index 16fb2d3..a45ff00 100644
> > > --- a/drivers/staging/wlan-ng/prism2mgmt.c
> > > +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> > > @@ -1307,8 +1307,7 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
> > >  		    && (msg->prismheader.data == P80211ENUM_truth_true)) {
> > >  			hw->sniffhdr = 0;
> > >  			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
> > > -		} else
> > > -		    if ((msg->wlanheader.status ==
> > > +		} else if ((msg->wlanheader.status ==
> > >  			 P80211ENUM_msgitem_status_data_ok)
> > >  			&& (msg->wlanheader.data == P80211ENUM_truth_true)) {
> > >  			hw->sniffhdr = 1;
> > 
> > This patch does not apply to my tree at all :(
> > 
> > Please rebase and resend the series.
> > 
> > thanks,
> > 
> > greg k-h
> 
> ok, I've got newest sources and this change is already applied. So what
> are the next steps suggested?

Suggested for what?

> I've heard there is a possibility to obtain mentor, right?

Mentor for what?

confused,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v7 0/2] staging: wlan-ng: align else if statement to coding  standard Maksymilian Piechota <maksymilianpiechota@gmail.com> - 2017-02-15 16:10 +0100
  [PATCH v7 2/2] staging: wlan-ng: move logical continuation at the  end of line Maksymilian Piechota <maksymilianpiechota@gmail.com> - 2017-02-15 16:20 +0100
  [PATCH v7 1/2] staging: wlan-ng: move else if statement to a single  line Maksymilian Piechota <maksymilianpiechota@gmail.com> - 2017-02-15 16:20 +0100
    Re: [PATCH v7 1/2] staging: wlan-ng: move else if statement to a  single line Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-16 19:30 +0100
      Re: [PATCH v7 1/2] staging: wlan-ng: move else if statement to a  single line Maksymilian Piechota <maksymilianpiechota@gmail.com> - 2017-02-17 15:40 +0100
        Re: [PATCH v7 1/2] staging: wlan-ng: move else if statement to a  single line Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-24 17:40 +0100

csiph-web