Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1587640
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 11/14] afs: inode: Replace rcu_assign_pointer() with RCU_INIT_POINTER() |
| Date | 2017-02-24 14:20 +0100 |
| Message-ID | <tenWX-FB-65@gated-at.bofh.it> (permalink) |
| References | <tenWV-FB-21@gated-at.bofh.it> |
| Organization | Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 |
From: Andreea-Cristina Bernat <bernat.ada@gmail.com> The use of "rcu_assign_pointer()" is NULLing out the pointer. According to RCU_INIT_POINTER()'s block comment: "1. This use of RCU_INIT_POINTER() is NULLing out the pointer" it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead. The following Coccinelle semantic patch was used: @@ @@ - rcu_assign_pointer + RCU_INIT_POINTER (..., NULL) Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com> Signed-off-by: David Howells <dhowells@redhat.com> --- fs/afs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/afs/inode.c b/fs/afs/inode.c index 8f4e70566e44..5707272adf18 100644 --- a/fs/afs/inode.c +++ b/fs/afs/inode.c @@ -447,7 +447,7 @@ void afs_evict_inode(struct inode *inode) mutex_lock(&vnode->permits_lock); permits = vnode->permits; - rcu_assign_pointer(vnode->permits, NULL); + RCU_INIT_POINTER(vnode->permits, NULL); mutex_unlock(&vnode->permits_lock); if (permits) call_rcu(&permits->rcu, afs_zap_permits);
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/14] AFS: Fixes and cleanups David Howells <dhowells@redhat.com> - 2017-02-24 14:20 +0100 [PATCH 11/14] afs: inode: Replace rcu_assign_pointer() with RCU_INIT_POINTER() David Howells <dhowells@redhat.com> - 2017-02-24 14:20 +0100 [PATCH 08/14] afs: Handle a short write to an AFS page David Howells <dhowells@redhat.com> - 2017-02-24 14:30 +0100 [PATCH 04/14] afs: Adjust mode bits processing David Howells <dhowells@redhat.com> - 2017-02-24 14:30 +0100 [PATCH 02/14] afs: Fix page overput in afs_fill_page() David Howells <dhowells@redhat.com> - 2017-02-24 14:30 +0100 [PATCH 09/14] afs: Flush outstanding writes when an fd is closed David Howells <dhowells@redhat.com> - 2017-02-24 14:30 +0100 [PATCH 14/14] afs: Prevent callback expiry timer overflow David Howells <dhowells@redhat.com> - 2017-02-24 14:30 +0100 [PATCH 03/14] afs: Populate group ID from vnode status David Howells <dhowells@redhat.com> - 2017-02-24 14:30 +0100
csiph-web