[PATCH v4 20/23] drm/rockchip: vop: test for P{H,V}SYNC

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!news.in-chemnitz.de!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	John Keeping <john@metanate.com>
Newsgroups	linux.kernel
Subject	[PATCH v4 20/23] drm/rockchip: vop: test for P{H,V}SYNC
Date	Fri, 24 Feb 2017 14:00:02 +0100
Message-ID	<tenDA-eO-7@gated-at.bofh.it> (permalink)
References	<tenDA-eO-5@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=metanate.com; s=stronger; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=VS7cPabpcn0aumYI2Hn+MlLY/rW6eMfuUwS3DtCH/d4=; b=e5z38al5RZgm7GKk5cuyD0MUur6rl0C/z740d9QEa4WIqsfO/MqysknlPAFYQ8b7pFXy70LVza3qeoO2Dk/26iXwb5MzaYWzD97JZ5N+aijigeq6nfju2YE9T9JghIJyMiz5FsAJfVGTyZktIiLq3wxeHh3SuIB5OS8re0WNGcKTL+wlKWjN7VlWqXfWr9ti8/m70zvom2ZahzC97IlpqbfhoIhsnbdiuFYrblFmJHg1pBWBM3G7c2e5W9HBTNRlyZnawyLbjWosedql+VzqtJEhbtAMVEmp5Ih5dqkUD72aXA1KfoHs4JOviLQpAcxPgFlo0p3bkDkc+3Aisp0CwA==;
X-Mailer	git-send-email 2.12.0.rc0.230.gf625d4cdb9.dirty
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	35
Organization	linux.* mail to news gateway
X-Original-Cc	Chris Zhong <zyw@rock-chips.com>, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Sean Paul <seanpaul@chromium.org>, John Keeping <john@metanate.com>
X-Original-Date	Fri, 24 Feb 2017 12:55:03 +0000
X-Original-Message-ID	<20170224125506.21533-21-john@metanate.com>
X-Original-References	<20170224125506.21533-1-john@metanate.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1587572

Show key headers only | View raw

When connected to the MIPI DSI output, we need to use N{H,V}SYNC for the
internal connection but these flags are meaningless for DSI panels.
Switch the test so that we do not set the P{H,V}SYNC bits unless the
mode requires it.

Signed-off-by: John Keeping <john@metanate.com>
Reviewed-by: Mark Yao <mark.yao@rock-chips.com>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
---
v4:
- Add Sean's Reviewed-by
v3:
- Add Mark's Reviewed-by
Unchanged in v2
---
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index c7eba305c488..67aefc6d4e9a 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -933,8 +933,8 @@ static void vop_crtc_enable(struct drm_crtc *crtc)
 	}
 
 	pin_pol = 0x8;
-	pin_pol |= (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC) ? 0 : 1;
-	pin_pol |= (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC) ? 0 : (1 << 1);
+	pin_pol |= (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC) ? 1 : 0;
+	pin_pol |= (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC) ? (1 << 1) : 0;
 	VOP_CTRL_SET(vop, pin_pol, pin_pol);
 
 	switch (s->output_type) {
-- 
2.12.0.rc0.230.gf625d4cdb9.dirty

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v4 20/23] drm/rockchip: vop: test for P{H,V}SYNC John Keeping <john@metanate.com> - 2017-02-24 14:00 +0100

csiph-web