Re: [PATCH v1 2/3] extcon: int3496: Rename GPIO pins in accordance with binding

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 2/3] extcon: int3496: Rename GPIO pins in accordance with binding
Date	2017-02-24 13:20 +0100
Message-ID	<ten0S-8s6-9@gated-at.bofh.it> (permalink)
References	<tdYYx-8q5-5@gated-at.bofh.it> <tecIa-11o-17@gated-at.bofh.it> <tdYYy-8q5-19@gated-at.bofh.it> <tecIa-11o-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Feb 24, 2017 at 3:17 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> On 2017년 02월 23일 19:31, Andy Shevchenko wrote:
>> First of all, add an optional binding for external muxer which might be
>> used.

>> --- a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
>> +++ b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
>> @@ -10,6 +10,9 @@ Either one of id-gpio or vbus-gpio must be present. Both can be present as well.
>>  - id-gpio: gpio for USB ID pin. See gpio binding.
>>  - vbus-gpio: gpio for USB VBUS pin.
>>
>> +Optional properties:
>> +- mux-gpios: gpio for USB external muxer
>
> The Documentation/extcon/intel-int3496.txt includes
> already the information for id/vbus/mux pin.

Thanks for pointing this out...

> The extcon-usb-gpio.txt is not related with the extcon-int3496 driver.

...but the bindings is related to ACPI somehow. I dunno why in
extcon-usb-gpio.c we have
        if (!np && !ACPI_HANDLE(dev))

...and thus it means either firmware chooses we better to have
standardized bindings in both cases.

OTOH mux-gpios indeed doesn't make sense for extcon-usb-gpio.c and
would be removed from the bindings.

I'll update patches accordingly.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 2/3] extcon: int3496: Rename GPIO pins in accordance with binding Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-02-23 11:40 +0100
  Re: [PATCH v1 2/3] extcon: int3496: Rename GPIO pins in accordance  with binding Chanwoo Choi <cw00.choi@samsung.com> - 2017-02-24 02:20 +0100
    Re: [PATCH v1 2/3] extcon: int3496: Rename GPIO pins in accordance  with binding Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-24 13:20 +0100

csiph-web