Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1587228

Re: [PATCH V4 1/6] mm: delete unnecessary TTU_* flags

Show all headers | View raw

On Wed, Feb 22, 2017 at 10:50:39AM -0800, Shaohua Li wrote:
> Johannes pointed out TTU_LZFREE is unnecessary. It's true because we
> always have the flag set if we want to do an unmap. For cases we don't
> do an unmap, the TTU_LZFREE part of code should never run.
> 
> Also the TTU_UNMAP is unnecessary. If no other flags set (for
> example, TTU_MIGRATION), an unmap is implied.
> 
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Hugh Dickins <hughd@google.com>
> Cc: Rik van Riel <riel@redhat.com>
> Cc: Mel Gorman <mgorman@techsingularity.net>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Suggested-by: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: Shaohua Li <shli@fb.com>
Acked-by: Minchan Kim <minchan@kernel.org>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V4 1/6] mm: delete unnecessary TTU_* flags Shaohua Li <shli@fb.com> - 2017-02-22 20:00 +0100
  Re: [PATCH V4 1/6] mm: delete unnecessary TTU_* flags Johannes Weiner <hannes@cmpxchg.org> - 2017-02-23 16:50 +0100
  Re: [PATCH V4 1/6] mm: delete unnecessary TTU_* flags Minchan Kim <minchan@kernel.org> - 2017-02-24 02:30 +0100
  Re: [PATCH V4 1/6] mm: delete unnecessary TTU_* flags "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-02-24 04:40 +0100

csiph-web