Re: [PATCH 1/2] x86, pkeys: check against max pkey to avoid overflows

From	"Kirill A. Shutemov" <kirill@shutemov.name>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] x86, pkeys: check against max pkey to avoid overflows
Date	2017-02-24 01:10 +0100
Message-ID	<tebCp-hQ-3@gated-at.bofh.it> (permalink)
References	<tea3E-7vC-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Feb 23, 2017 at 02:26:03PM -0800, Dave Hansen wrote:
> 
> From: Dave Hansen <dave.hansen@linux.intel.com>
> 
> Kirill got a warning from UBSAN about undefined behavior when using
> protection keys.  He is running on hardware that actually has support
> for it, which is not widely available.
> 
> The warning was because we did some very large shifts of integers when
> doing a pkey_free() of a large, invalid value because we never check
> that the pkey "fits" into the mm_pkey_allocation_map().
> 
> I do not believe there is any danger here of anything bad happening
> other than some aliasing issues where somebody could do:
> 
> 	pkey_free(35);
> 
> and the kernel would effectively execute:
> 
> 	pkey_free(8);
> 
> While this might be confusing to an app that was doing something
> stupid, it has to do something stupid and the effects are limited to
> the app shooting itself in the foot.
> 
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
 Kirill A. Shutemov

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] x86, pkeys: check against max pkey to avoid overflows Dave Hansen <dave.hansen@linux.intel.com> - 2017-02-23 23:30 +0100
  Re: [PATCH 1/2] x86, pkeys: check against max pkey to avoid overflows "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-02-24 01:10 +0100

csiph-web