Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588205

Re: [PATCH] input: cpcap-pwrbutton: new driver

Show all headers | View raw

* Dmitry Torokhov <dmitry.torokhov@gmail.com> [170225 11:00]:
> On Fri, Feb 24, 2017 at 09:59:09AM +0100, Sebastian Reichel wrote:
> > +#include <linux/mfd/motorola-cpcap.h>
> > +
> > +#define CPCAP_IRQ_ON 23
> > +#define CPCAP_IRQ_ON_BITMASK (1 << (CPCAP_IRQ_ON % 16))
> 
> Is this truly static or it could depend= on IRQ returned by
> platform_get_irq()?

I suggest we add it to include/linux/mfd/motorola-cpcap.h:

static inline int cpcap_get_irq_status(struct device *dev,
				       struct regmap *regmap,
				       int irq,
				       u16 *status);

Or do you guys have better ideas?

I'll be needing that for the USB PHY driver too for multiple
bits so we want to return the whole bank register in status.

We may want to change to do that later to avoid dependencies
or set up an immutable branch with just that change.

Other than that things work for me based on a quick test.

Regards,

Tony

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] input: cpcap-pwrbutton: new driver Sebastian Reichel <sre@kernel.org> - 2017-02-24 10:00 +0100
  Re: [PATCH] input: cpcap-pwrbutton: new driver Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-25 20:10 +0100
    Re: [PATCH] input: cpcap-pwrbutton: new driver Tony Lindgren <tony@atomide.com> - 2017-02-25 20:30 +0100
      Re: [PATCH] input: cpcap-pwrbutton: new driver Tony Lindgren <tony@atomide.com> - 2017-02-28 03:40 +0100
  Re: [PATCH] input: cpcap-pwrbutton: new driver Rob Herring <robh@kernel.org> - 2017-02-28 01:30 +0100

csiph-web