Re: [PATCH] ASoC: tegra: Remove unnecessary 'Block comments should align the * on each line' message

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Julia Lawall <julia.lawall@lip6.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ASoC: tegra: Remove unnecessary 'Block comments should align the * on each line' message
Date	Sat, 25 Feb 2017 20:00:02 +0100
Message-ID	<tePJw-3Ad-13@gated-at.bofh.it> (permalink)
References	<tePJv-3Ad-1@gated-at.bofh.it>
X-Original-To	Codrut Grosu <codrut.cristian.grosu@gmail.com>
X-Ironport-Av	E=Sophos;i="5.35,203,1484002800"; d="scan'208";a="214707582"
X-X-Sender	jll@hadrien
User-Agent	Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	57
Organization	linux.* mail to news gateway
X-Original-Cc	perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com, broonie@kernel.org, swarren@wwwdotorg.org, thierry.reding@gmail.com, gnurou@gmail.com, Julia.Lawall@lip6.fr, nicoleotsuka@gmail.com, alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Sat, 25 Feb 2017 19:57:01 +0100 (CET)
X-Original-Message-ID	<alpine.DEB.2.20.1702251955110.2179@hadrien>
X-Original-References	<1488048686-5964-1-git-send-email-codrut.cristian.grosu@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1588198

Show key headers only | View raw

The subject line is not very accurate.  You don't remove the message, in
the sense of picking it up and putting it somewhere else.  You adjust the
code in some way such that the error no longer occurs.  So it would be
better to say what adjustment you have done.  Something like line up *s in
block comments.

julia



On Sat, 25 Feb 2017, Codrut Grosu wrote:

> This was reported by checkpatch.pl
>
> Signed-off-by: Codrut Grosu <codrut.cristian.grosu@gmail.com>
> ---
>  sound/soc/tegra/tegra_alc5632.c | 2 +-
>  sound/soc/tegra/tegra_rt5640.c  | 2 +-
>  sound/soc/tegra/tegra_rt5677.c  | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/tegra/tegra_alc5632.c b/sound/soc/tegra/tegra_alc5632.c
> index 0509902..1f648f9 100644
> --- a/sound/soc/tegra/tegra_alc5632.c
> +++ b/sound/soc/tegra/tegra_alc5632.c
> @@ -1,5 +1,5 @@
>  /*
> -* tegra_alc5632.c  --  Toshiba AC100(PAZ00) machine ASoC driver
> + * tegra_alc5632.c  --  Toshiba AC100(PAZ00) machine ASoC driver
>   *
>   * Copyright (C) 2011 The AC100 Kernel Team <ac100@lists.lauchpad.net>
>   * Copyright (C) 2012 - NVIDIA, Inc.
> diff --git a/sound/soc/tegra/tegra_rt5640.c b/sound/soc/tegra/tegra_rt5640.c
> index 93a3568..cf706d0 100644
> --- a/sound/soc/tegra/tegra_rt5640.c
> +++ b/sound/soc/tegra/tegra_rt5640.c
> @@ -1,5 +1,5 @@
>  /*
> -* tegra_rt5640.c - Tegra machine ASoC driver for boards using RT5640 codec.
> + * tegra_rt5640.c - Tegra machine ASoC driver for boards using RT5640 codec.
>   *
>   * Copyright (c) 2013, NVIDIA CORPORATION.  All rights reserved.
>   *
> diff --git a/sound/soc/tegra/tegra_rt5677.c b/sound/soc/tegra/tegra_rt5677.c
> index ebf58d0..0ed2eca 100644
> --- a/sound/soc/tegra/tegra_rt5677.c
> +++ b/sound/soc/tegra/tegra_rt5677.c
> @@ -1,5 +1,5 @@
>  /*
> -* tegra_rt5677.c - Tegra machine ASoC driver for boards using RT5677 codec.
> + * tegra_rt5677.c - Tegra machine ASoC driver for boards using RT5677 codec.
>   *
>   * Copyright (c) 2014, The Chromium OS Authors.  All rights reserved.
>   *
> 1.9.1
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: tegra: Remove unnecessary 'Block comments should align the * on each line' message Codrut Grosu <codrut.cristian.grosu@gmail.com> - 2017-02-25 20:00 +0100
  Re: [PATCH] ASoC: tegra: Remove unnecessary 'Block comments should  align the * on each line' message Julia Lawall <julia.lawall@lip6.fr> - 2017-02-25 20:00 +0100

csiph-web