Re: [RFC 4/4] iio: trigger: add GPIO trigger

From	Jonathan Cameron <jic23@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC 4/4] iio: trigger: add GPIO trigger
Date	2017-02-25 17:30 +0100
Message-ID	<teNol-23w-1@gated-at.bofh.it> (permalink)
References	<tbTgC-6tv-5@gated-at.bofh.it> <tbTgC-6tv-17@gated-at.bofh.it> <tbTqi-6zb-43@gated-at.bofh.it> <tciRH-5QK-9@gated-at.bofh.it> <tcZ0C-6Yp-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 20/02/17 16:24, Fabrice Gasnier wrote:
> On 02/18/2017 08:19 PM, Jonathan Cameron wrote:
>> On 17/02/17 16:16, Lars-Peter Clausen wrote:
>>> On 02/17/2017 05:03 PM, Fabrice Gasnier wrote:
>>>> GPIOs can be used to generate triggers for any IIO device.
>>>> Introduce generic GPIO trigger driver. It offers some options
>>>> to tune polarity (e.g. rising/falling edge), and label so trigger
>>>> name may be customized.
>>>> By default, gpio triggers will be named gpiotrigX, where X is gpio
>>>> number as returned by desc_to_gpio() call.
>>>> Rising edge is selected if polarity isn't set.
>>>
>>> If you want to use the GPIO only as an interrupt, just use it as an
>>> interrupt directly, no need to go the route via the GPIO.
>> Absolutely.  The majority of the bindings will then just become standard
>> interrupt bindings and will be effectively handled for you.
>>
>> Please work to extend the existing interrupt trigger driver rather than adding
>> this new one.  That one actually started as a gpio trigger then got
>> generalised into a interrupt trigger later so lets not do that again ;)
> 
> Hi Lars, Jonathan
> 
> Ok, got it.
> I'll drop this and focus on interrupt trigger, if this is worth having DT for it (e.g. patch 1 & 2 of this RFC).
> 
> BTW, I figured out there has been this patch a year ago, on interrupt trigger, to add device tree support:
> http://www.spinics.net/lists/linux-iio/msg23126.html
> Any reason why it hasn't found its way in ?
Gregor being very busy I suspect and not having time to address the reviews.

I 'think' the conclusion then was we needed some representative device that
could exist in devicetree to allow us to specify that a particular interrupt
could be used to trigger sensor capture.

Not a big issue, but probably still needs implementing unless Gregor has had
a chance to look at this.

Jonathan


> 
> Thanks for reviewing,
> Best Regards,
> Fabrice
> 
>>
>> Jonathan
>>
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thread

[RFC 0/4] iio: trigger: Add OF support and GPIO based trigger Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-02-17 17:10 +0100
  [RFC 1/4] dt-bindings: iio: introduce trigger providers, consumers Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-02-17 17:10 +0100
  [RFC 4/4] iio: trigger: add GPIO trigger Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-02-17 17:10 +0100
    Re: [RFC 4/4] iio: trigger: add GPIO trigger Lars-Peter Clausen <lars@metafoo.de> - 2017-02-17 17:20 +0100
      Re: [RFC 4/4] iio: trigger: add GPIO trigger Jonathan Cameron <jic23@kernel.org> - 2017-02-18 20:30 +0100
        Re: [RFC 4/4] iio: trigger: add GPIO trigger Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-02-20 17:30 +0100
          Re: [RFC 4/4] iio: trigger: add GPIO trigger Jonathan Cameron <jic23@kernel.org> - 2017-02-25 17:30 +0100
  [RFC 2/4] iio: trigger: add OF support Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-02-17 17:10 +0100
  [RFC 3/4] dt-bindings: iio: add support for GPIO triggers Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-02-17 17:10 +0100
    Re: [RFC 3/4] dt-bindings: iio: add support for GPIO triggers Jonathan Cameron <jic23@kernel.org> - 2017-02-18 20:30 +0100
    Re: [RFC 3/4] dt-bindings: iio: add support for GPIO triggers Linus Walleij <linus.walleij@linaro.org> - 2017-02-23 16:20 +0100
      Re: [RFC 3/4] dt-bindings: iio: add support for GPIO triggers Fabrice Gasnier <fabrice.gasnier@st.com> - 2017-02-23 16:50 +0100
  Re: [RFC 0/4] iio: trigger: Add OF support and GPIO based trigger Daniel Baluta <daniel.baluta@gmail.com> - 2017-02-17 17:30 +0100
    Re: [RFC 0/4] iio: trigger: Add OF support and GPIO based trigger Jonathan Cameron <jic23@kernel.org> - 2017-02-18 20:20 +0100

csiph-web